Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ssm_parameter: Enable to change type from SecureString to String #10819

Merged
merged 1 commit into from
Jan 24, 2020
Merged

resource/aws_ssm_parameter: Enable to change type from SecureString to String #10819

merged 1 commit into from
Jan 24, 2020

Conversation

chroju
Copy link
Contributor

@chroju chroju commented Nov 9, 2019

Fix #9843. Enable to change ssm parameter type from SecureString to String .

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9843

Release note for CHANGELOG:

* resource/aws_ssm_parameter: Enable to change type from SecureString to String

Output from acceptance testing:

❯ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMParameter_updateType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMParameter_updateType -timeout 120m
=== RUN   TestAccAWSSSMParameter_updateType
=== PAUSE TestAccAWSSSMParameter_updateType
=== CONT  TestAccAWSSSMParameter_updateType
--- PASS: TestAccAWSSSMParameter_updateType (60.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       60.964s

@chroju chroju requested a review from a team November 9, 2019 13:00
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 9, 2019
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 24, 2020
@bflad bflad added this to the v2.47.0 milestone Jan 24, 2020
bflad
bflad approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix @chroju 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSSMParameter_disappears (14.20s)
--- PASS: TestAccAWSSSMParameter_fullPath (20.62s)
--- PASS: TestAccAWSSSMParameter_secure (21.53s)
--- PASS: TestAccAWSSSMParameter_basic (21.98s)
--- PASS: TestAccAWSSSMParameter_updateDescription (34.06s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (34.44s)
--- PASS: TestAccAWSSSMParameter_updateType (35.23s)
--- PASS: TestAccAWSSSMParameter_overwrite (36.26s)
--- PASS: TestAccAWSSSMParameter_Tier (46.00s)
--- PASS: TestAccAWSSSMParameter_tags (48.53s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (51.77s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (69.76s)

aws/resource_aws_ssm_parameter_test.go
@@ -486,6 +516,20 @@ resource "aws_ssm_parameter" "test" {
`, rName, pType, value)
}

func testAccAWSSSMParameterBasicConfigTypeUpdated(rName, pType, value string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This test configuration function looks identical to testAccAWSSSMParameterBasicConfig so will consolidate these on merge. 👍

@bflad bflad merged commit 55dd263 into hashicorp:master Jan 24, 2020
bflad added a commit that referenced this pull request Jan 24, 2020
@bflad
Update CHANGELOG for #10819
e9a22c0
@ghost
Copy link

ghost commented Jan 30, 2020

This has been released in version 2.47.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.47.0
Development

Successfully merging this pull request may close these issues.

aws_ssm_parameter does not support changing type from SecureString => String
2 participants
@chroju @bflad