Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] data source for aws_iam_saml_provider #7283

Closed
mlehner616 opened this issue Jan 24, 2019 · 6 comments · Fixed by #10498
Closed

[Feature] data source for aws_iam_saml_provider #7283

mlehner616 opened this issue Jan 24, 2019 · 6 comments · Fixed by #10498
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-data-source Introduces a new data source. service/iam Issues and PRs that pertain to the iam service.
Milestone
v4.10.0

Comments

@mlehner616
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There is already a resource for aws_iam_saml_provider. I'd like to be able to lookup existing resources outside of terraform using a data source for aws_iam_saml_provider to use a single provider in multiple terraform states.
@mlehner616 mlehner616 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 24, 2019
@bflad bflad added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-data-source Introduces a new data source. service/iam Issues and PRs that pertain to the iam service. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Apr 11, 2019
@asp7479
Copy link

asp7479 commented Oct 2, 2019

Was there a solution for this ?. I already have a SAML provider in my AWS account and I would like to just create roles and associate the existing SAML instead of creating SAML provider with metadata extract everytime. Please update ?!

@alpacamybags118
Copy link
Contributor

@asp7479 @mlehner616 i started to look/work on this today - going to try and get a PR in sometime this week / weekend.

@alpacamybags118 alpacamybags118 mentioned this issue Oct 14, 2019
Merged
@alpacamybags118
Copy link
Contributor

I added a PR for this over a year ago but it never got reviewed. I recently updated it to meet the newer standards. Hoping to get some eyes on as the automation didn't tag it as needs-triage. Maybe you might know the best way to get this tagged for review @bflad ?

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@github-actions github-actions bot added this to the v4.10.0 milestone Apr 8, 2022
@github-actions
Copy link

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-data-source Introduces a new data source. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
Milestone
v4.10.0
Development

Successfully merging a pull request may close this issue.

Adding IAM SAML Provider Data source alpacamybags118/terraform-provider-aws
5 participants
@bflad @breathingdust @mlehner616 @alpacamybags118 @asp7479