-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource] TimestreamInfluxDB DB Instance #37963
[New Resource] TimestreamInfluxDB DB Instance #37963
Conversation
Community NoteVoting for Prioritization
For Submitters
|
I have addressed all failing checks. I have updated the output of the acceptance tests after the latest changes. This PR is ready for review. cc @johnsonaj |
Hi! Are there any updates on this PR? 😄 |
@hc-github-team-terraform-aws Hi! any updates? |
Hi all, this could be merged? |
This PR is complete and needs assistance to review and merge. Note: Currently, Timestream for InfluxDB does not support creating multiple database instances in parallel. This is why I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS="-run=TestAccTimestreamInfluxDBDBInstance_" PKG=timestreaminfluxdb ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/timestreaminfluxdb/... -v -count 1 -parallel 3 -run=TestAccTimestreamInfluxDBDBInstance_ -timeout 360m
db_instance_tags_gen_test.go:204: Tags with null values are not correctly handled with the Plugin Framework
--- SKIP: TestAccTimestreamInfluxDBDBInstance_tags_null (0.00s)
db_instance_tags_gen_test.go:1523: Tags with null values are not correctly handled with the Plugin Framework
--- SKIP: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag (0.00s)
db_instance_tags_gen_test.go:1590: Tags with null values are not correctly handled with the Plugin Framework
--- SKIP: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag (0.00s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly (878.56s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags (882.29s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag (991.37s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly (609.35s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly (1349.81s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add (1936.40s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace (1862.04s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_basic (1892.17s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_deploymentTypeMultiAzStandby (1692.02s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_publiclyAccessible (557.90s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping (2206.01s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration (1496.61s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_disappears (753.26s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add (661.75s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping (2319.23s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace (845.38s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate (970.87s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate (2264.00s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate (799.56s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag (1904.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/timestreaminfluxdb 9596.592s
@trevorbonas thank you for the contribution! 🎉 |
This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
aws_timestreaminfluxdb_db_instance
resource added.aws_timestreaminfluxdb_db_instance
.aws_timestreaminfluxdb_db_instance
.aws_timestreaminfluxdb_db_instance
.Relations
Closes #36398
References
TimestreamInfluxDB AWS SDK Go v2 package: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb@v1.0.5#pkg-index
Timestream for InfluxDB documentation: https://docs.aws.amazon.com/timestream/latest/developerguide/timestream-for-influxdb.html
Output from Acceptance Testing