add aws_appfabric_ingestion_destination resource

[professional-ian]

Description

This pr adds a resource for aws_appfabric_ingestion_destination

Relations

Closes #34549.

References

https://docs.aws.amazon.com/appfabric/latest/api/API_CreateIngestionDestination.html

Output from Acceptance Testing

% make testacc TESTS=TestAccAppFabricIngestionDestination PKG=appfabric
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appfabric/... -v -count 1 -parallel 20 -run='TestAccAppFabricIngestionDestination'  -timeout 360m
=== RUN   TestAccAppFabricIngestionDestination_basic
=== PAUSE TestAccAppFabricIngestionDestination_basic
=== RUN   TestAccAppFabricIngestionDestination_firehose
--- PASS: TestAccAppFabricIngestionDestination_firehose (10.18s)
=== RUN   TestAccAppFabricIngestionDestination_destinationUpdate
=== PAUSE TestAccAppFabricIngestionDestination_destinationUpdate
=== RUN   TestAccAppFabricIngestionDestination_disappears
=== PAUSE TestAccAppFabricIngestionDestination_disappears
=== CONT  TestAccAppFabricIngestionDestination_basic
=== CONT  TestAccAppFabricIngestionDestination_disappears
=== CONT  TestAccAppFabricIngestionDestination_destinationUpdate
--- PASS: TestAccAppFabricIngestionDestination_disappears (10.71s)
--- PASS: TestAccAppFabricIngestionDestination_basic (12.63s)
--- PASS: TestAccAppFabricIngestionDestination_destinationUpdate (19.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appfabric  36.599s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @professional-ian 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[meetreks]

Looks good now. I think we are still missing change log and html documentation,

[github-actions]

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

[meetreks]

Very good first contribution. A few things to check

1. Has the tests covered all possible API values populated even though they are optional?
2. Similar comment for fields which can be updated.
3. you can move all wait code to a separate file

[ewbankkit]

LGTM 🚀.

% AWS_APPFABRIC_TERRAFORMCLOUD_TENANT_ID=... AWS_APPFABRIC_TERRAFORMCLOUD_SERVICE_ACCOUNT_TOKEN=... AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAppFabric_serial/IngestionDestination' PKG=appfabric 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/appfabric/... -v -count 1 -parallel 20  -run=TestAccAppFabric_serial/IngestionDestination -timeout 360m
=== RUN   TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT  TestAccAppFabric_serial
=== RUN   TestAccAppFabric_serial/IngestionDestination
=== RUN   TestAccAppFabric_serial/IngestionDestination/tags
=== RUN   TestAccAppFabric_serial/IngestionDestination/update
=== RUN   TestAccAppFabric_serial/IngestionDestination/firehose
=== RUN   TestAccAppFabric_serial/IngestionDestination/basic
=== RUN   TestAccAppFabric_serial/IngestionDestination/disappears
--- PASS: TestAccAppFabric_serial (223.51s)
    --- PASS: TestAccAppFabric_serial/IngestionDestination (223.51s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/tags (35.35s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/update (28.53s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/firehose (110.26s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/basic (21.80s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/disappears (20.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appfabric	227.813s

[ewbankkit]

@professional-ian Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.