-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aws_appfabric_ingestion_destination resource #37627
add aws_appfabric_ingestion_destination resource #37627
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @professional-ian 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. I think we are still missing change log and html documentation,
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good first contribution. A few things to check
- Has the tests covered all possible API values populated even though they are optional?
- Similar comment for fields which can be updated.
- you can move all wait code to a separate file
# Conflicts: # internal/service/appfabric/exports_test.go # internal/service/appfabric/service_package_gen.go
… 0 or 2; Actual: 1]'.
… a single newline character'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AWS_APPFABRIC_TERRAFORMCLOUD_TENANT_ID=... AWS_APPFABRIC_TERRAFORMCLOUD_SERVICE_ACCOUNT_TOKEN=... AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAppFabric_serial/IngestionDestination' PKG=appfabric
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/appfabric/... -v -count 1 -parallel 20 -run=TestAccAppFabric_serial/IngestionDestination -timeout 360m
=== RUN TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT TestAccAppFabric_serial
=== RUN TestAccAppFabric_serial/IngestionDestination
=== RUN TestAccAppFabric_serial/IngestionDestination/tags
=== RUN TestAccAppFabric_serial/IngestionDestination/update
=== RUN TestAccAppFabric_serial/IngestionDestination/firehose
=== RUN TestAccAppFabric_serial/IngestionDestination/basic
=== RUN TestAccAppFabric_serial/IngestionDestination/disappears
--- PASS: TestAccAppFabric_serial (223.51s)
--- PASS: TestAccAppFabric_serial/IngestionDestination (223.51s)
--- PASS: TestAccAppFabric_serial/IngestionDestination/tags (35.35s)
--- PASS: TestAccAppFabric_serial/IngestionDestination/update (28.53s)
--- PASS: TestAccAppFabric_serial/IngestionDestination/firehose (110.26s)
--- PASS: TestAccAppFabric_serial/IngestionDestination/basic (21.80s)
--- PASS: TestAccAppFabric_serial/IngestionDestination/disappears (20.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appfabric 227.813s
@professional-ian Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pr adds a resource for aws_appfabric_ingestion_destination
Relations
Closes #34549.
References
https://docs.aws.amazon.com/appfabric/latest/api/API_CreateIngestionDestination.html
Output from Acceptance Testing