Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support for AWS WAF v2 body inspection size #36979

Closed
mkwtsec opened this issue Apr 18, 2024 · 5 comments · Fixed by #37588
Closed

[Enhancement]: Support for AWS WAF v2 body inspection size #36979

mkwtsec opened this issue Apr 18, 2024 · 5 comments · Fixed by #37588
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@mkwtsec
Copy link

mkwtsec commented Apr 18, 2024

Description

AWS WAF v2 now supports a higher default HTTP body inspection size. Additionally it can be increased beyond the new default.

Affected Resource(s) and/or Data Source(s)

aws_wafv2_web_acl_association

The documentation should also be updated to reflect the larger inspection size

Potential Terraform Configuration

Perhaps modify the `default_size_inspection_limit` to be a top-level setting in the resource?

References

https://aws.amazon.com/about-aws/whats-new/2024/03/aws-waf-larger-body-inspections-regional-resources/

Would you like to implement a fix?

None

@mkwtsec mkwtsec added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 18, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 18, 2024
@acwwat
Copy link
Contributor

acwwat commented Apr 26, 2024

The new setting should be implemented usingassoication_config block in the aws_wafv2_web_acl resource. It currently exists but only support CloudFront, in a format that's not as flexible as a similar block like custom_response_body with a key. See API reference for details.

@justinretzolk justinretzolk added service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 6, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.51.0 milestone May 20, 2024
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
3 participants