-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update operation for authorizer id on apigatewayv2 route #35821
Fix update operation for authorizer id on apigatewayv2 route #35821
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @vubogovich 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAPIGatewayV2Route_' PKG=apigatewayv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 2 -run=TestAccAPIGatewayV2Route_ -timeout 360m
=== RUN TestAccAPIGatewayV2Route_basic
=== PAUSE TestAccAPIGatewayV2Route_basic
=== RUN TestAccAPIGatewayV2Route_disappears
=== PAUSE TestAccAPIGatewayV2Route_disappears
=== RUN TestAccAPIGatewayV2Route_authorizer
=== PAUSE TestAccAPIGatewayV2Route_authorizer
=== RUN TestAccAPIGatewayV2Route_jwtAuthorization
=== PAUSE TestAccAPIGatewayV2Route_jwtAuthorization
=== RUN TestAccAPIGatewayV2Route_model
=== PAUSE TestAccAPIGatewayV2Route_model
=== RUN TestAccAPIGatewayV2Route_requestParameters
=== PAUSE TestAccAPIGatewayV2Route_requestParameters
=== RUN TestAccAPIGatewayV2Route_simpleAttributes
=== PAUSE TestAccAPIGatewayV2Route_simpleAttributes
=== RUN TestAccAPIGatewayV2Route_target
=== PAUSE TestAccAPIGatewayV2Route_target
=== RUN TestAccAPIGatewayV2Route_updateRouteKey
=== PAUSE TestAccAPIGatewayV2Route_updateRouteKey
=== CONT TestAccAPIGatewayV2Route_basic
=== CONT TestAccAPIGatewayV2Route_requestParameters
=== CONT TestAccAPIGatewayV2Route_target
--- PASS: TestAccAPIGatewayV2Route_basic (42.25s)
--- PASS: TestAccAPIGatewayV2Route_target (42.76s)
=== CONT TestAccAPIGatewayV2Route_updateRouteKey
--- PASS: TestAccAPIGatewayV2Route_requestParameters (90.08s)
=== CONT TestAccAPIGatewayV2Route_jwtAuthorization
--- PASS: TestAccAPIGatewayV2Route_updateRouteKey (59.53s)
=== CONT TestAccAPIGatewayV2Route_model
--- PASS: TestAccAPIGatewayV2Route_jwtAuthorization (91.54s)
=== CONT TestAccAPIGatewayV2Route_authorizer
--- PASS: TestAccAPIGatewayV2Route_model (40.46s)
=== CONT TestAccAPIGatewayV2Route_disappears
--- PASS: TestAccAPIGatewayV2Route_disappears (34.45s)
=== CONT TestAccAPIGatewayV2Route_simpleAttributes
--- PASS: TestAccAPIGatewayV2Route_authorizer (97.45s)
--- PASS: TestAccAPIGatewayV2Route_simpleAttributes (79.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2 332.541s
@vubogovich Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The change from
to
results in the following error:
which can be reproduced using AWS CLI
while the following is working
So the solution is to include
authorization_type
on the change ofauthorizer_id
when aws provider updatesaws_apigatewayv2_route
resource.