-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix when importing a msk storage app autoscaling policy #34934
fix when importing a msk storage app autoscaling policy #34934
Conversation
Community NoteVoting for Prioritization
For Submitters
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @trentbitterman 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppAutoScalingPolicy_' PKG=appautoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appautoscaling/... -v -count 1 -parallel 3 -run=TestAccAppAutoScalingPolicy_ -timeout 360m
=== RUN TestAccAppAutoScalingPolicy_basic
=== PAUSE TestAccAppAutoScalingPolicy_basic
=== RUN TestAccAppAutoScalingPolicy_disappears
=== PAUSE TestAccAppAutoScalingPolicy_disappears
=== RUN TestAccAppAutoScalingPolicy_scaleOutAndIn
=== PAUSE TestAccAppAutoScalingPolicy_scaleOutAndIn
=== RUN TestAccAppAutoScalingPolicy_spotFleetRequest
=== PAUSE TestAccAppAutoScalingPolicy_spotFleetRequest
=== RUN TestAccAppAutoScalingPolicy_DynamoDB_table
=== PAUSE TestAccAppAutoScalingPolicy_DynamoDB_table
=== RUN TestAccAppAutoScalingPolicy_DynamoDB_index
=== PAUSE TestAccAppAutoScalingPolicy_DynamoDB_index
=== RUN TestAccAppAutoScalingPolicy_multiplePoliciesSameName
=== PAUSE TestAccAppAutoScalingPolicy_multiplePoliciesSameName
=== RUN TestAccAppAutoScalingPolicy_multiplePoliciesSameResource
=== PAUSE TestAccAppAutoScalingPolicy_multiplePoliciesSameResource
=== RUN TestAccAppAutoScalingPolicy_ResourceID_forceNew
=== PAUSE TestAccAppAutoScalingPolicy_ResourceID_forceNew
=== RUN TestAccAppAutoScalingPolicy_TargetTrack_metricMath
=== PAUSE TestAccAppAutoScalingPolicy_TargetTrack_metricMath
=== CONT TestAccAppAutoScalingPolicy_basic
=== CONT TestAccAppAutoScalingPolicy_DynamoDB_index
=== CONT TestAccAppAutoScalingPolicy_ResourceID_forceNew
--- PASS: TestAccAppAutoScalingPolicy_DynamoDB_index (46.85s)
=== CONT TestAccAppAutoScalingPolicy_spotFleetRequest
--- PASS: TestAccAppAutoScalingPolicy_basic (75.17s)
=== CONT TestAccAppAutoScalingPolicy_DynamoDB_table
--- PASS: TestAccAppAutoScalingPolicy_ResourceID_forceNew (89.79s)
=== CONT TestAccAppAutoScalingPolicy_multiplePoliciesSameResource
--- PASS: TestAccAppAutoScalingPolicy_DynamoDB_table (34.51s)
=== CONT TestAccAppAutoScalingPolicy_multiplePoliciesSameName
--- PASS: TestAccAppAutoScalingPolicy_multiplePoliciesSameResource (39.36s)
=== CONT TestAccAppAutoScalingPolicy_scaleOutAndIn
--- PASS: TestAccAppAutoScalingPolicy_spotFleetRequest (87.79s)
=== CONT TestAccAppAutoScalingPolicy_TargetTrack_metricMath
--- PASS: TestAccAppAutoScalingPolicy_multiplePoliciesSameName (33.65s)
=== CONT TestAccAppAutoScalingPolicy_disappears
--- PASS: TestAccAppAutoScalingPolicy_scaleOutAndIn (81.32s)
--- PASS: TestAccAppAutoScalingPolicy_TargetTrack_metricMath (77.48s)
--- PASS: TestAccAppAutoScalingPolicy_disappears (72.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling 223.252s
This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR fixes an issue when importing a MSK app autoscaling policy that is caused by the resource id containing more
/
characters than expected.Relations
Closes #34933
References
Output from Acceptance Testing