-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow periods in parameter group names for RDS #33704
Conversation
Community NoteVoting for Prioritization
For Submitters
|
adopting the ordering outlined in the regular expression contributing guide: https://hashicorp.github.io/terraform-provider-aws/regular-expressions/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=rds TESTS=TestAccRDSParameterGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSParameterGroup_' -timeout 360m
--- PASS: TestAccRDSParameterGroup_disappears (26.68s)
--- PASS: TestAccRDSParameterGroup_namePrefix (31.83s)
--- PASS: TestAccRDSParameterGroup_only (32.67s)
--- PASS: TestAccRDSParameterGroup_matchDefault (32.87s)
--- PASS: TestAccRDSParameterGroup_generatedName (37.97s)
--- PASS: TestAccRDSParameterGroup_withApplyMethod (39.45s)
--- PASS: TestAccRDSParameterGroup_updateParameters (60.20s)
--- PASS: TestAccRDSParameterGroup_caseParameters (63.82s)
--- PASS: TestAccRDSParameterGroup_basic (82.67s)
--- PASS: TestAccRDSParameterGroup_limit (83.37s)
--- PASS: TestAccRDSParameterGroup_caseWithMixedParameters (84.01s)
--- PASS: TestAccRDSParameterGroup_tags (86.84s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 89.978s
% make testacc PKG=rds TESTS=TestAccRDSClusterParameterGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterParameterGroup_' -timeout 360m
--- PASS: TestAccRDSClusterParameterGroup_disappears (28.79s)
--- PASS: TestAccRDSClusterParameterGroup_dynamicDiffs (33.26s)
--- PASS: TestAccRDSClusterParameterGroup_generatedName (34.97s)
--- PASS: TestAccRDSClusterParameterGroup_only (36.13s)
--- PASS: TestAccRDSClusterParameterGroup_GeneratedName_parameter (36.58s)
--- PASS: TestAccRDSClusterParameterGroup_withApplyMethod (37.44s)
--- PASS: TestAccRDSClusterParameterGroup_NamePrefix_parameter (37.46s)
--- PASS: TestAccRDSClusterParameterGroup_namePrefix (37.65s)
--- PASS: TestAccRDSClusterParameterGroup_caseParameters (49.68s)
--- PASS: TestAccRDSClusterParameterGroup_updateParameters (51.79s)
--- PASS: TestAccRDSClusterParameterGroup_tags (64.55s)
--- PASS: TestAccRDSClusterParameterGroup_basic (70.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 73.938s
Note that custom group names still cannot be created using periods, however, this should prevent the provider side validation failures when default parameter groups are imported and used as inputs to other resources. These default groups cannot be updated once imported (AWS does not allow modification of default parameter groups). |
Thanks for your contribution, @autotune! 👏 |
This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Relations
Closes #12144
Output from Acceptance Testing