-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the opensearch with standby functionality #33031
Added the opensearch with standby functionality #33031
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mikekinlock 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…lti-az-with-standby
…multi_az_with_standby_enabled' is true.
…-standby' of github.com:mikekinlock/terraform-provider-aws into f-opensearch-adding-cluster-configuration-multi-az-with-standby
… and `cluster_config.dedicated_master_type` as Computed.
…uration-multi-az-with-standby
…r_count` and `cluster_config.dedicated_master_type` as Computed." This reverts commit 726175f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_advanced\|TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_Cluster_' PKG=opensearch ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 3 -run=TestAccOpenSearchDomainDataSource_Data_advanced\|TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_Cluster_ -timeout 720m
=== RUN TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN TestAccOpenSearchDomain_Cluster_zoneAwareness
=== PAUSE TestAccOpenSearchDomain_Cluster_zoneAwareness
=== RUN TestAccOpenSearchDomain_Cluster_coldStorage
=== PAUSE TestAccOpenSearchDomain_Cluster_coldStorage
=== RUN TestAccOpenSearchDomain_Cluster_warm
=== PAUSE TestAccOpenSearchDomain_Cluster_warm
=== RUN TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== RUN TestAccOpenSearchDomain_Cluster_update
=== PAUSE TestAccOpenSearchDomain_Cluster_update
=== RUN TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== PAUSE TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== CONT TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT TestAccOpenSearchDomain_Cluster_warm
=== CONT TestAccOpenSearchDomain_Cluster_zoneAwareness
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2493.19s)
=== CONT TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomain_basic (1923.63s)
=== CONT TestAccOpenSearchDomain_Cluster_coldStorage
--- PASS: TestAccOpenSearchDomain_Cluster_warm (5251.12s)
=== CONT TestAccOpenSearchDomain_Cluster_update
--- PASS: TestAccOpenSearchDomain_Cluster_zoneAwareness (7575.42s)
=== CONT TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (3621.94s)
=== CONT TestAccOpenSearchDomain_Cluster_dedicatedMaster
--- PASS: TestAccOpenSearchDomain_Cluster_update (4570.21s)
--- PASS: TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled (2958.39s)
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedMaster (6241.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 14285.490s
@mikekinlock Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This bug might have been fixed but the latest documentations are not updated, so I am at a loss here how to use it. |
@amiryoni thanks for the info, I'll ask in slack If I should update the documentations or if that is done by someone else but in the meanwhile you can use it just like the AWS CLI Command Reference See here
|
I think documentation is not updated yet ewbankkit mikekinlock |
Thanks @mikekinlock. I really appreciate the contribution. ❤️ |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Change
Description
Relations
Closes #31373
References
As a reference to this change I've used the AWS-CLI documentations and followed their setup structure. Meaning other than requested in the issue, I've added the
MultiAZWithStandbyEnabled
configuration undercluster-config
and not undervpc_options
Output from Acceptance Testing
The following test is currently failing and I'm not sure how to solve it yet, point is that the created resource is already deleted once the test is trying to verify its configuration. Here I would kindly ask for support. In this case I'm leaning on the
best effort
clause in your contributor guide% make testacc TESTS=TestAccDomainConfig_multiAzWithStandby PKG=opensearch