Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source] fsx_ontap_storage_virtual_machines #32624

Merged

Conversation

R-Campbell
Copy link
Contributor

Description

Add a data source to allow the retrieval of FSx ONTAP Storage Virtual Machine IDs from AWS.

Relations

Relates #30348

References

https://docs.aws.amazon.com/fsx/latest/APIReference/API_DescribeStorageVirtualMachines.html
docs.aws.amazon.com/fsx/latest/APIReference/API_StorageVirtualMachineFilter.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccFSxOntapStorageVirtualMachinesDataSource PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOntapStorageVirtualMachinesDataSource'  -timeout 180m
=== RUN   TestAccFSxOntapStorageVirtualMachinesDataSource_Filter
=== PAUSE TestAccFSxOntapStorageVirtualMachinesDataSource_Filter
=== CONT  TestAccFSxOntapStorageVirtualMachinesDataSource_Filter
--- PASS: TestAccFSxOntapStorageVirtualMachinesDataSource_Filter (2288.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2292.103s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fsx Issues and PRs that pertain to the fsx service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 20, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jul 20, 2023
@R-Campbell R-Campbell changed the title add storage_virtual_machines data source Add fsx_ontap_storage_virtual_machines data source Jul 20, 2023
@R-Campbell R-Campbell changed the title Add fsx_ontap_storage_virtual_machines data source [New Data Source] fsx_ontap_storage_virtual_machines Jul 21, 2023
@R-Campbell R-Campbell changed the title [New Data Source] fsx_ontap_storage_virtual_machines [New Data Source] fsx_ontap_storage_virtual_machines Jul 21, 2023
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 24, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFSxONTAPStorageVirtualMachinesDataSource_' PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20  -run=TestAccFSxONTAPStorageVirtualMachinesDataSource_ -timeout 360m
=== RUN   TestAccFSxONTAPStorageVirtualMachinesDataSource_Filter
=== PAUSE TestAccFSxONTAPStorageVirtualMachinesDataSource_Filter
=== CONT  TestAccFSxONTAPStorageVirtualMachinesDataSource_Filter
--- PASS: TestAccFSxONTAPStorageVirtualMachinesDataSource_Filter (2277.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2283.196s

@ewbankkit
Copy link
Contributor

@R-Campbell Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 57f32fb into hashicorp:main Sep 20, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.18.0 milestone Sep 20, 2023
@github-actions
Copy link

This functionality has been released in v5.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants