Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CleanRooms Collaboration Resource #31680

Merged
merged 22 commits into from
Jul 5, 2023

Conversation

chrsteff
Copy link
Contributor

@chrsteff chrsteff commented May 31, 2023

Description

The change adds a new resource, the Clean Rooms Collaboration resource.

References

https://docs.aws.amazon.com/clean-rooms/latest/apireference/API_Collaboration.html

Output from Acceptance Testing

$ make testacc PKG=cleanrooms

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cleanrooms/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestAccCleanRoomsCollaboration_basic
=== PAUSE TestAccCleanRoomsCollaboration_basic
=== RUN   TestAccCleanRoomsCollaboration_disappears
=== PAUSE TestAccCleanRoomsCollaboration_disappears
=== RUN   TestAccCleanRoomsCollaboration_mutableProperties
=== PAUSE TestAccCleanRoomsCollaboration_mutableProperties
=== RUN   TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== PAUSE TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== RUN   TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== PAUSE TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== RUN   TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== PAUSE TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== RUN   TestAccCleanRoomsCollaboration_updateMemberAbilities
=== PAUSE TestAccCleanRoomsCollaboration_updateMemberAbilities
=== CONT  TestAccCleanRoomsCollaboration_basic
=== CONT  TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== CONT  TestAccCleanRoomsCollaboration_mutableProperties
=== CONT  TestAccCleanRoomsCollaboration_updateMemberAbilities
=== CONT  TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== CONT  TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== CONT  TestAccCleanRoomsCollaboration_disappears
--- PASS: TestAccCleanRoomsCollaboration_disappears (36.83s)
--- PASS: TestAccCleanRoomsCollaboration_basic (49.23s)
--- PASS: TestAccCleanRoomsCollaboration_updateCreatorDisplayName (73.67s)
--- PASS: TestAccCleanRoomsCollaboration_mutableProperties (73.77s)
--- PASS: TestAccCleanRoomsCollaboration_updateQueryLogStatus (78.15s)
--- PASS: TestAccCleanRoomsCollaboration_updateMemberAbilities (78.63s)
--- PASS: TestAccCleanRoomsCollaboration_dataEncryptionSettings (97.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 104.602s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. generators Relates to code generators. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 31, 2023
@chrsteff chrsteff changed the title F cleanrooms collaboration Add CleanRooms Collaboration Resource May 31, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 31, 2023
@AdamTylerLynch AdamTylerLynch added the partner Contribution from a partner. label Jun 8, 2023
@ewbankkit ewbankkit self-assigned this Jul 5, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCleanRoomsCollaboration_' PKG=cleanrooms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cleanrooms/... -v -count 1 -parallel 2  -run=TestAccCleanRoomsCollaboration_ -timeout 180m
=== RUN   TestAccCleanRoomsCollaboration_basic
=== PAUSE TestAccCleanRoomsCollaboration_basic
=== RUN   TestAccCleanRoomsCollaboration_disappears
=== PAUSE TestAccCleanRoomsCollaboration_disappears
=== RUN   TestAccCleanRoomsCollaboration_mutableProperties
=== PAUSE TestAccCleanRoomsCollaboration_mutableProperties
=== RUN   TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== PAUSE TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== RUN   TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== PAUSE TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== RUN   TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== PAUSE TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== RUN   TestAccCleanRoomsCollaboration_updateMemberAbilities
=== PAUSE TestAccCleanRoomsCollaboration_updateMemberAbilities
=== CONT  TestAccCleanRoomsCollaboration_basic
=== CONT  TestAccCleanRoomsCollaboration_updateQueryLogStatus
--- PASS: TestAccCleanRoomsCollaboration_basic (32.42s)
=== CONT  TestAccCleanRoomsCollaboration_updateMemberAbilities
--- PASS: TestAccCleanRoomsCollaboration_updateQueryLogStatus (53.77s)
=== CONT  TestAccCleanRoomsCollaboration_dataEncryptionSettings
--- PASS: TestAccCleanRoomsCollaboration_updateMemberAbilities (49.34s)
=== CONT  TestAccCleanRoomsCollaboration_mutableProperties
--- PASS: TestAccCleanRoomsCollaboration_dataEncryptionSettings (66.78s)
=== CONT  TestAccCleanRoomsCollaboration_updateCreatorDisplayName
--- PASS: TestAccCleanRoomsCollaboration_mutableProperties (47.49s)
=== CONT  TestAccCleanRoomsCollaboration_disappears
--- PASS: TestAccCleanRoomsCollaboration_disappears (20.32s)
--- PASS: TestAccCleanRoomsCollaboration_updateCreatorDisplayName (45.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms	171.955s

@ewbankkit
Copy link
Contributor

@chrsteff Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ab7e071 into hashicorp:main Jul 5, 2023
51 checks passed
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@chrsteff chrsteff deleted the f-cleanrooms-collaboration branch July 10, 2023 15:52
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants