-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GlobalSettings resource for Amazon Chime SDK voice connector #31365
Adding GlobalSettings resource for Amazon Chime SDK voice connector #31365
Conversation
Community NoteVoting for Prioritization
For Submitters
|
- use diags in crud handlers - handle eventual consistency on create - simplify flex functions - change voice_connector to TypeList - handle out of band settings changes - add _disappears, _update tests
…s, adjust description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=chimesdkvoice TESTS=TestAccChimeSDKVoiceGlobalSettings_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20 -run='TestAccChimeSDKVoiceGlobalSettings_serial' -timeout 180m
=== RUN TestAccChimeSDKVoiceGlobalSettings_serial
=== PAUSE TestAccChimeSDKVoiceGlobalSettings_serial
=== CONT TestAccChimeSDKVoiceGlobalSettings_serial
=== RUN TestAccChimeSDKVoiceGlobalSettings_serial/update
=== RUN TestAccChimeSDKVoiceGlobalSettings_serial/basic
=== RUN TestAccChimeSDKVoiceGlobalSettings_serial/disappears
--- PASS: TestAccChimeSDKVoiceGlobalSettings_serial (45.28s)
--- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/update (20.69s)
--- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/basic (13.05s)
--- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/disappears (11.53s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice 48.436s
Thanks for your contribution, @Prateeksharma13! 👏 |
This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adding GlobalSettings resource for Amazon Chime SDK voice connector
This will help users to set the s3 bucket destination for CallDetailRecords for voice connector calls.
Example terraform confiiguration:
Relations
Closes #31362
References
https://docs.aws.amazon.com/chime-sdk/latest/APIReference/API_voice-chime_UpdateGlobalSettings.html
https://docs.aws.amazon.com/chime-sdk/latest/APIReference/API_voice-chime_GetGlobalSettings.html
https://docs.aws.amazon.com/chime-sdk/latest/APIReference/API_Operations_Amazon_Chime_SDK_Voice.html
Output from Acceptance Testing