Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Explorer service client #28084

Merged
merged 18 commits into from
Nov 30, 2022
Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 29, 2022

Description

  • Adds the Resource Explorer service client
  • As part of EC2-Classic retirement (EC2-Classic Retirement #23625), deprecates the provider's skip_get_ec2_platforms configuration argument
  • Generates initialization of AWS Go SDK v2 API clients
  • Generates lazy-load AWS Go SDK v2 API clients for services that use both AWS Go SDK v1 and AWS Go SDK v2

Relations

Relates #27717.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccLogsDataProtectionPolicy_basic' PKG=logs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 20  -run=TestAccLogsDataProtectionPolicy_basic -timeout 180m
=== RUN   TestAccLogsDataProtectionPolicy_basic
=== PAUSE TestAccLogsDataProtectionPolicy_basic
=== CONT  TestAccLogsDataProtectionPolicy_basic
--- PASS: TestAccLogsDataProtectionPolicy_basic (23.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	28.169s
% make testacc TESTARGS='-run=TestAccS3ControlStorageLensConfiguration_basic' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlStorageLensConfiguration_basic -timeout 180m
=== RUN   TestAccS3ControlStorageLensConfiguration_basic
=== PAUSE TestAccS3ControlStorageLensConfiguration_basic
=== CONT  TestAccS3ControlStorageLensConfiguration_basic
--- PASS: TestAccS3ControlStorageLensConfiguration_basic (15.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	20.440s
% make testacc TESTARGS='-run=TestAccRolesAnywhereTrustAnchor_basic' PKG=rolesanywhere
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rolesanywhere/... -v -count 1 -parallel 20  -run=TestAccRolesAnywhereTrustAnchor_basic -timeout 180m
=== RUN   TestAccRolesAnywhereTrustAnchor_basic
=== PAUSE TestAccRolesAnywhereTrustAnchor_basic
=== CONT  TestAccRolesAnywhereTrustAnchor_basic
--- PASS: TestAccRolesAnywhereTrustAnchor_basic (28.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere	34.227s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/s3control Issues and PRs that pertain to the s3control service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 29, 2022
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Nov 30, 2022
@ewbankkit ewbankkit marked this pull request as ready for review November 30, 2022 20:24
@ewbankkit ewbankkit merged commit 97f90cd into main Nov 30, 2022
@ewbankkit ewbankkit deleted the f-resource-explorer-service branch November 30, 2022 21:26
@github-actions github-actions bot added this to the v4.45.0 milestone Nov 30, 2022
github-actions bot pushed a commit that referenced this pull request Nov 30, 2022
@ewbankkit ewbankkit added the service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. label Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v4.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/s3control Issues and PRs that pertain to the s3control service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant