Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/aws_connect_contact_flow - type force new #27347

Merged

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Oct 20, 2022

Description

Add a ForceNew on the type argument

Relations

Closes #26790

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccConnect_serial/ContactFlow/' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/ContactFlow/ -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/ContactFlow
=== RUN   TestAccConnect_serial/ContactFlow/basic
=== RUN   TestAccConnect_serial/ContactFlow/disappears
=== RUN   TestAccConnect_serial/ContactFlow/filename
=== RUN   TestAccConnect_serial/ContactFlow/dataSource_id
=== RUN   TestAccConnect_serial/ContactFlow/dataSource_name
=== RUN   TestAccConnect_serial/ContactFlowModule
=== RUN   TestAccConnect_serial/ContactFlowModule/dataSource_id
=== RUN   TestAccConnect_serial/ContactFlowModule/dataSource_name
=== RUN   TestAccConnect_serial/ContactFlowModule/basic
=== RUN   TestAccConnect_serial/ContactFlowModule/disappears
=== RUN   TestAccConnect_serial/ContactFlowModule/filename
--- PASS: TestAccConnect_serial (1031.22s)
    --- PASS: TestAccConnect_serial/ContactFlow (504.88s)
        --- PASS: TestAccConnect_serial/ContactFlow/basic (121.92s)
        --- PASS: TestAccConnect_serial/ContactFlow/disappears (91.59s)
        --- PASS: TestAccConnect_serial/ContactFlow/filename (105.12s)
        --- PASS: TestAccConnect_serial/ContactFlow/dataSource_id (92.65s)
        --- PASS: TestAccConnect_serial/ContactFlow/dataSource_name (93.59s)
    --- PASS: TestAccConnect_serial/ContactFlowModule (526.34s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/dataSource_id (92.37s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/dataSource_name (93.47s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/basic (114.23s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/disappears (90.89s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/filename (135.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1031.536s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/connect Issues and PRs that pertain to the connect service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Oct 20, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022
Copy link
Contributor

@schuylr schuylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 verified that Contact Flow types cannot be updated, and therefore require a force new.

@johnsonaj johnsonaj self-requested a review October 21, 2022 20:16
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccConnect_serial/ContactFlow/' PKG=connect

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/ContactFlow/ -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/ContactFlow
=== RUN   TestAccConnect_serial/ContactFlow/basic
=== RUN   TestAccConnect_serial/ContactFlow/disappears
=== RUN   TestAccConnect_serial/ContactFlow/filename
=== RUN   TestAccConnect_serial/ContactFlow/dataSource_id
=== RUN   TestAccConnect_serial/ContactFlow/dataSource_name
=== RUN   TestAccConnect_serial/ContactFlowModule
=== RUN   TestAccConnect_serial/ContactFlowModule/basic
=== RUN   TestAccConnect_serial/ContactFlowModule/disappears
=== RUN   TestAccConnect_serial/ContactFlowModule/filename
=== RUN   TestAccConnect_serial/ContactFlowModule/dataSource_id
=== RUN   TestAccConnect_serial/ContactFlowModule/dataSource_name
--- PASS: TestAccConnect_serial (865.47s)
    --- PASS: TestAccConnect_serial/ContactFlow (439.18s)
        --- PASS: TestAccConnect_serial/ContactFlow/basic (96.85s)
        --- PASS: TestAccConnect_serial/ContactFlow/disappears (81.10s)
        --- PASS: TestAccConnect_serial/ContactFlow/filename (96.52s)
        --- PASS: TestAccConnect_serial/ContactFlow/dataSource_id (82.04s)
        --- PASS: TestAccConnect_serial/ContactFlow/dataSource_name (82.67s)
    --- PASS: TestAccConnect_serial/ContactFlowModule (426.29s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/basic (95.01s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/disappears (70.89s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/filename (95.96s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/dataSource_id (81.74s)
        --- PASS: TestAccConnect_serial/ContactFlowModule/dataSource_name (82.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	868.091s

@johnsonaj
Copy link
Contributor

@GlennChia thanks for the contribution! 👏🏾 🎉

@johnsonaj johnsonaj merged commit 2fad01b into hashicorp:main Oct 21, 2022
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 21, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_connect_contact_flow should destroy/create when type changes
5 participants