Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for DX Router Configuration #27341

Merged
merged 8 commits into from
Oct 25, 2022

Conversation

schuylr
Copy link
Contributor

@schuylr schuylr commented Oct 19, 2022

Description

Adds the aws_dx_router_configuration data source to allow users to download sample router configurations for their Direct Connect VIF.

Relations

Closes #26432

References

https://docs.aws.amazon.com/directconnect/latest/UserGuide/create-vif.html#vif-router-config
https://docs.aws.amazon.com/sdk-for-go/api/service/directconnect/#DirectConnect.DescribeRouterConfiguration
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directconnect#Client.DescribeRouterConfiguration
https://docs.aws.amazon.com/directconnect/latest/APIReference/API_DescribeRouterConfiguration.html
https://docs.aws.amazon.com/directconnect/latest/APIReference/API_RouterType.html

Output from Acceptance Testing

Note that a DX VIF must be provided via the VIRTUAL_INTERFACE_ID env variable.

terraform-provider-aws % AWS_DEFAULT_REGION=eu-west-1 VIRTUAL_INTERFACE_ID=dxvif-xxxxxxxx make testacc TESTS=TestAccDirectConnectRouterConfigurationDataSource_basic PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 20 -run='TestAccDirectConnectRouterConfigurationDataSource_basic'  -timeout 180m
=== RUN   TestAccDirectConnectRouterConfigurationDataSource_basic
=== PAUSE TestAccDirectConnectRouterConfigurationDataSource_basic
=== CONT  TestAccDirectConnectRouterConfigurationDataSource_basic
--- PASS: TestAccDirectConnectRouterConfigurationDataSource_basic (19.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	23.515s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/directconnect Issues and PRs that pertain to the directconnect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Oct 19, 2022
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, requesting small styling changes, no functional changes required.

Co-authored-by: Glenn <glennchia7@gmail.com>
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccDirectConnectRouterConfigurationDataSource_ PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 20 -run='TestAccDirectConnectRouterConfigurationDataSource_'  -timeout 180m
=== RUN   TestAccDirectConnectRouterConfigurationDataSource_basic
    router_configuration_data_source_test.go:17: Environment variable VIRTUAL_INTERFACE_ID is not set
--- SKIP: TestAccDirectConnectRouterConfigurationDataSource_basic (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	4.891s

@ewbankkit
Copy link
Contributor

@schuylr Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit babd5d8 into hashicorp:main Oct 25, 2022
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 25, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/directconnect Issues and PRs that pertain to the directconnect service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New aws_dx_virtual_interface_router_configuration data source
4 participants