Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_identitystore_user #26948

Merged
merged 29 commits into from
Sep 27, 2022

Conversation

roberth-k
Copy link
Contributor

@roberth-k roberth-k commented Sep 22, 2022

Closes #26607.

Output from acceptance testing:

$ make testacc TESTS=TestAccIdentityStoreUser_ PKG=identitystore
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreUser_'  -timeout 180m
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== RUN   TestAccIdentityStoreUser_disappears
=== PAUSE TestAccIdentityStoreUser_disappears
=== RUN   TestAccIdentityStoreUser_Addresses
=== PAUSE TestAccIdentityStoreUser_Addresses
=== RUN   TestAccIdentityStoreUser_Emails
=== PAUSE TestAccIdentityStoreUser_Emails
=== RUN   TestAccIdentityStoreUser_Locale
=== PAUSE TestAccIdentityStoreUser_Locale
=== RUN   TestAccIdentityStoreUser_NameFamilyName
=== PAUSE TestAccIdentityStoreUser_NameFamilyName
=== RUN   TestAccIdentityStoreUser_NameFormatted
=== PAUSE TestAccIdentityStoreUser_NameFormatted
=== RUN   TestAccIdentityStoreUser_NameGivenName
=== PAUSE TestAccIdentityStoreUser_NameGivenName
=== RUN   TestAccIdentityStoreUser_NameHonorificPrefix
=== PAUSE TestAccIdentityStoreUser_NameHonorificPrefix
=== RUN   TestAccIdentityStoreUser_NameHonorificSuffix
=== PAUSE TestAccIdentityStoreUser_NameHonorificSuffix
=== RUN   TestAccIdentityStoreUser_NameMiddleName
=== PAUSE TestAccIdentityStoreUser_NameMiddleName
=== RUN   TestAccIdentityStoreUser_NickName
=== PAUSE TestAccIdentityStoreUser_NickName
=== RUN   TestAccIdentityStoreUser_PhoneNumbers
=== PAUSE TestAccIdentityStoreUser_PhoneNumbers
=== RUN   TestAccIdentityStoreUser_PreferredLanguage
=== PAUSE TestAccIdentityStoreUser_PreferredLanguage
=== RUN   TestAccIdentityStoreUser_ProfileURL
=== PAUSE TestAccIdentityStoreUser_ProfileURL
=== RUN   TestAccIdentityStoreUser_Timezone
=== PAUSE TestAccIdentityStoreUser_Timezone
=== RUN   TestAccIdentityStoreUser_Title
=== PAUSE TestAccIdentityStoreUser_Title
=== RUN   TestAccIdentityStoreUser_UserType
=== PAUSE TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUser_basic
=== CONT  TestAccIdentityStoreUser_NameHonorificSuffix
=== CONT  TestAccIdentityStoreUser_Locale
=== CONT  TestAccIdentityStoreUser_ProfileURL
=== CONT  TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUser_Title
=== CONT  TestAccIdentityStoreUser_Timezone
=== CONT  TestAccIdentityStoreUser_NameFamilyName
=== CONT  TestAccIdentityStoreUser_NameHonorificPrefix
=== CONT  TestAccIdentityStoreUser_NameGivenName
=== CONT  TestAccIdentityStoreUser_NameFormatted
=== CONT  TestAccIdentityStoreUser_PhoneNumbers
=== CONT  TestAccIdentityStoreUser_PreferredLanguage
=== CONT  TestAccIdentityStoreUser_NickName
=== CONT  TestAccIdentityStoreUser_NameMiddleName
=== CONT  TestAccIdentityStoreUser_Emails
=== CONT  TestAccIdentityStoreUser_Addresses
=== CONT  TestAccIdentityStoreUser_disappears
--- PASS: TestAccIdentityStoreUser_disappears (25.63s)
--- PASS: TestAccIdentityStoreUser_basic (29.19s)
--- PASS: TestAccIdentityStoreUser_NameHonorificPrefix (50.19s)
--- PASS: TestAccIdentityStoreUser_NameFamilyName (50.27s)
--- PASS: TestAccIdentityStoreUser_NameGivenName (50.31s)
--- PASS: TestAccIdentityStoreUser_Title (65.69s)
--- PASS: TestAccIdentityStoreUser_NameHonorificSuffix (67.01s)
--- PASS: TestAccIdentityStoreUser_ProfileURL (67.02s)
--- PASS: TestAccIdentityStoreUser_NameFormatted (67.30s)
--- PASS: TestAccIdentityStoreUser_NickName (67.34s)
--- PASS: TestAccIdentityStoreUser_Locale (67.39s)
--- PASS: TestAccIdentityStoreUser_UserType (67.43s)
--- PASS: TestAccIdentityStoreUser_NameMiddleName (67.47s)
--- PASS: TestAccIdentityStoreUser_PreferredLanguage (67.48s)
--- PASS: TestAccIdentityStoreUser_Timezone (67.62s)
--- PASS: TestAccIdentityStoreUser_Addresses (74.49s)
--- PASS: TestAccIdentityStoreUser_Emails (75.53s)
--- PASS: TestAccIdentityStoreUser_PhoneNumbers (75.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      77.322s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/identitystore Issues and PRs that pertain to the identitystore service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Sep 22, 2022
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Sep 22, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 27, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIdentityStoreUser_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreUser_ -timeout 180m
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== RUN   TestAccIdentityStoreUser_disappears
=== PAUSE TestAccIdentityStoreUser_disappears
=== RUN   TestAccIdentityStoreUser_Addresses
=== PAUSE TestAccIdentityStoreUser_Addresses
=== RUN   TestAccIdentityStoreUser_Emails
=== PAUSE TestAccIdentityStoreUser_Emails
=== RUN   TestAccIdentityStoreUser_Locale
=== PAUSE TestAccIdentityStoreUser_Locale
=== RUN   TestAccIdentityStoreUser_NameFamilyName
=== PAUSE TestAccIdentityStoreUser_NameFamilyName
=== RUN   TestAccIdentityStoreUser_NameFormatted
=== PAUSE TestAccIdentityStoreUser_NameFormatted
=== RUN   TestAccIdentityStoreUser_NameGivenName
=== PAUSE TestAccIdentityStoreUser_NameGivenName
=== RUN   TestAccIdentityStoreUser_NameHonorificPrefix
=== PAUSE TestAccIdentityStoreUser_NameHonorificPrefix
=== RUN   TestAccIdentityStoreUser_NameHonorificSuffix
=== PAUSE TestAccIdentityStoreUser_NameHonorificSuffix
=== RUN   TestAccIdentityStoreUser_NameMiddleName
=== PAUSE TestAccIdentityStoreUser_NameMiddleName
=== RUN   TestAccIdentityStoreUser_NickName
=== PAUSE TestAccIdentityStoreUser_NickName
=== RUN   TestAccIdentityStoreUser_PhoneNumbers
=== PAUSE TestAccIdentityStoreUser_PhoneNumbers
=== RUN   TestAccIdentityStoreUser_PreferredLanguage
=== PAUSE TestAccIdentityStoreUser_PreferredLanguage
=== RUN   TestAccIdentityStoreUser_ProfileURL
=== PAUSE TestAccIdentityStoreUser_ProfileURL
=== RUN   TestAccIdentityStoreUser_Timezone
=== PAUSE TestAccIdentityStoreUser_Timezone
=== RUN   TestAccIdentityStoreUser_Title
=== PAUSE TestAccIdentityStoreUser_Title
=== RUN   TestAccIdentityStoreUser_UserType
=== PAUSE TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUser_basic
=== CONT  TestAccIdentityStoreUser_NameHonorificSuffix
--- PASS: TestAccIdentityStoreUser_basic (30.23s)
=== CONT  TestAccIdentityStoreUser_ProfileURL
--- PASS: TestAccIdentityStoreUser_NameHonorificSuffix (69.34s)
=== CONT  TestAccIdentityStoreUser_UserType
--- PASS: TestAccIdentityStoreUser_ProfileURL (62.61s)
=== CONT  TestAccIdentityStoreUser_Title
--- PASS: TestAccIdentityStoreUser_UserType (65.22s)
=== CONT  TestAccIdentityStoreUser_Timezone
--- PASS: TestAccIdentityStoreUser_Title (61.25s)
=== CONT  TestAccIdentityStoreUser_PhoneNumbers
--- PASS: TestAccIdentityStoreUser_Timezone (54.31s)
=== CONT  TestAccIdentityStoreUser_NickName
--- PASS: TestAccIdentityStoreUser_PhoneNumbers (81.44s)
=== CONT  TestAccIdentityStoreUser_NameMiddleName
--- PASS: TestAccIdentityStoreUser_NickName (59.12s)
=== CONT  TestAccIdentityStoreUser_NameFamilyName
--- PASS: TestAccIdentityStoreUser_NameFamilyName (38.40s)
=== CONT  TestAccIdentityStoreUser_NameHonorificPrefix
--- PASS: TestAccIdentityStoreUser_NameMiddleName (56.64s)
=== CONT  TestAccIdentityStoreUser_NameGivenName
--- PASS: TestAccIdentityStoreUser_NameHonorificPrefix (39.71s)
=== CONT  TestAccIdentityStoreUser_NameFormatted
--- PASS: TestAccIdentityStoreUser_NameGivenName (36.79s)
=== CONT  TestAccIdentityStoreUser_Emails
--- PASS: TestAccIdentityStoreUser_NameFormatted (53.31s)
=== CONT  TestAccIdentityStoreUser_Locale
--- PASS: TestAccIdentityStoreUser_Emails (76.34s)
=== CONT  TestAccIdentityStoreUser_Addresses
--- PASS: TestAccIdentityStoreUser_Locale (68.46s)
=== CONT  TestAccIdentityStoreUser_disappears
--- PASS: TestAccIdentityStoreUser_disappears (17.18s)
=== CONT  TestAccIdentityStoreUser_PreferredLanguage
--- PASS: TestAccIdentityStoreUser_Addresses (87.55s)
--- PASS: TestAccIdentityStoreUser_PreferredLanguage (52.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	525.435s

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 27, 2022

@roberth-k Thanks for the contribution 🎉 👏.
I renamed the nick_name attribute to nickname as that's the correct English spelling (according to the Internet).

@github-actions
Copy link

This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/identitystore Issues and PRs that pertain to the identitystore service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Resource: aws_identitystore_user
2 participants