r/aws_connect_instance_storage_config

[GlennChia]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23332

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnect_serial/InstanceStorageConfig' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnect_serial/InstanceStorageConfig -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/InstanceStorageConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/S3Config_EncryptionConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/basic
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisFirehoseConfig_FirehoseARN
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_EncryptionConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Retention
=== RUN   TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketName
=== RUN   TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketPrefix
=== RUN   TestAccConnect_serial/InstanceStorageConfig/disappears
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisStreamConfig_StreamARN
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Prefix
--- PASS: TestAccConnect_serial (1241.13s)
    --- PASS: TestAccConnect_serial/InstanceStorageConfig (1241.13s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_EncryptionConfig (138.85s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/basic (95.61s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisFirehoseConfig_FirehoseARN (224.21s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_EncryptionConfig (128.29s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Retention (113.10s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketName (116.66s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketPrefix (116.45s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/disappears (91.14s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisStreamConfig_StreamARN (104.32s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Prefix (112.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1241.198s
...

[gdavison]

Thanks for the PR, @GlennChia. I have a few suggestions for changes

[GlennChia]

Ran acceptance tests after review changes:

$ make testacc TESTARGS='-run=TestAccConnect_serial/InstanceStorageConfig' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnect_serial/InstanceStorageConfig -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/InstanceStorageConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/S3Config_EncryptionConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/basic
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisFirehoseConfig_FirehoseARN
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_EncryptionConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Retention
=== RUN   TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketName
=== RUN   TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketPrefix
=== RUN   TestAccConnect_serial/InstanceStorageConfig/disappears
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisStreamConfig_StreamARN
=== RUN   TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Prefix
--- PASS: TestAccConnect_serial (1241.13s)
    --- PASS: TestAccConnect_serial/InstanceStorageConfig (1241.13s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_EncryptionConfig (138.85s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/basic (95.61s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisFirehoseConfig_FirehoseARN (224.21s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_EncryptionConfig (128.29s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Retention (113.10s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketName (116.66s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketPrefix (116.45s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/disappears (91.14s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisStreamConfig_StreamARN (104.32s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Prefix (112.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1241.198s

[gdavison]

LGTM 🚀

--- PASS: TestAccConnect_serial (24907.67s)
--- PASS: TestAccConnect_serial/LambdaFunctionAssociation (267.01s)
--- PASS: TestAccConnect_serial/LambdaFunctionAssociation/basic (93.28s)
--- PASS: TestAccConnect_serial/LambdaFunctionAssociation/disappears (86.83s)
--- PASS: TestAccConnect_serial/LambdaFunctionAssociation/dataSource_basic (86.91s)
--- PASS: TestAccConnect_serial/User (871.98s)
--- PASS: TestAccConnect_serial/User/phoneConfig (152.35s)
--- PASS: TestAccConnect_serial/User/routingProfileId (115.07s)
--- PASS: TestAccConnect_serial/User/securityProfileIds (138.48s)
--- PASS: TestAccConnect_serial/User/basic (65.36s)
--- PASS: TestAccConnect_serial/User/disappears (91.18s)
--- PASS: TestAccConnect_serial/User/tags (107.78s)
--- PASS: TestAccConnect_serial/User/hierarchyGroupId (99.60s)
--- PASS: TestAccConnect_serial/User/identityInfo (102.16s)
--- PASS: TestAccConnect_serial/ContactFlow (419.52s)
--- PASS: TestAccConnect_serial/ContactFlow/basic (89.60s)
--- PASS: TestAccConnect_serial/ContactFlow/disappears (78.50s)
--- PASS: TestAccConnect_serial/ContactFlow/filename (91.17s)
--- PASS: TestAccConnect_serial/ContactFlow/dataSource_id (79.66s)
--- PASS: TestAccConnect_serial/ContactFlow/dataSource_name (80.58s)
--- PASS: TestAccConnect_serial/ContactFlowModule (416.30s)
--- PASS: TestAccConnect_serial/ContactFlowModule/filename (89.79s)
--- PASS: TestAccConnect_serial/ContactFlowModule/dataSource_id (78.79s)
--- PASS: TestAccConnect_serial/ContactFlowModule/dataSource_name (80.24s)
--- PASS: TestAccConnect_serial/ContactFlowModule/basic (89.69s)
--- PASS: TestAccConnect_serial/ContactFlowModule/disappears (77.80s)
--- PASS: TestAccConnect_serial/RoutingProfile (638.02s)
--- PASS: TestAccConnect_serial/RoutingProfile/defaultOutboundQueue (92.66s)
--- PASS: TestAccConnect_serial/RoutingProfile/queues (107.89s)
--- PASS: TestAccConnect_serial/RoutingProfile/dataSource_id (79.66s)
--- PASS: TestAccConnect_serial/RoutingProfile/dataSource_name (81.27s)
--- PASS: TestAccConnect_serial/RoutingProfile/basic (82.07s)
--- SKIP: TestAccConnect_serial/RoutingProfile/disappears (0.00s)
--- PASS: TestAccConnect_serial/RoutingProfile/tags (102.25s)
--- PASS: TestAccConnect_serial/RoutingProfile/concurrency (92.23s)
--- PASS: TestAccConnect_serial/Vocabulary (16957.15s)
--- PASS: TestAccConnect_serial/Vocabulary/basic (5610.50s)
--- PASS: TestAccConnect_serial/Vocabulary/disappears (5692.36s)
--- PASS: TestAccConnect_serial/Vocabulary/tags (5654.30s)
--- PASS: TestAccConnect_serial/Prompt (76.65s)
--- PASS: TestAccConnect_serial/Prompt/dataSource_name (76.65s)
--- PASS: TestAccConnect_serial/QuickConnect (429.53s)
--- PASS: TestAccConnect_serial/QuickConnect/dataSource_id (79.86s)
--- PASS: TestAccConnect_serial/QuickConnect/dataSource_name (78.18s)
--- PASS: TestAccConnect_serial/QuickConnect/basic (98.30s)
--- PASS: TestAccConnect_serial/QuickConnect/disappears (76.88s)
--- PASS: TestAccConnect_serial/QuickConnect/tags (96.30s)
--- PASS: TestAccConnect_serial/SecurityProfile (490.13s)
--- PASS: TestAccConnect_serial/SecurityProfile/basic (88.26s)
--- PASS: TestAccConnect_serial/SecurityProfile/disappears (58.02s)
--- PASS: TestAccConnect_serial/SecurityProfile/tags (98.54s)
--- PASS: TestAccConnect_serial/SecurityProfile/permissions (88.80s)
--- PASS: TestAccConnect_serial/SecurityProfile/dataSource_id (78.03s)
--- PASS: TestAccConnect_serial/SecurityProfile/dataSource_name (78.48s)
--- PASS: TestAccConnect_serial/UserHierarchyStructure (282.77s)
--- PASS: TestAccConnect_serial/UserHierarchyStructure/dataSource_id (76.57s)
--- PASS: TestAccConnect_serial/UserHierarchyStructure/basic (129.90s)
--- PASS: TestAccConnect_serial/UserHierarchyStructure/disappears (76.29s)
--- PASS: TestAccConnect_serial/BotAssociation (239.50s)
--- PASS: TestAccConnect_serial/BotAssociation/basic (80.50s)
--- PASS: TestAccConnect_serial/BotAssociation/disappears (78.83s)
--- PASS: TestAccConnect_serial/BotAssociation/dataSource_basic (80.17s)
--- PASS: TestAccConnect_serial/Queue (749.53s)
--- PASS: TestAccConnect_serial/Queue/basic (91.18s)
--- SKIP: TestAccConnect_serial/Queue/disappears (0.00s)
--- PASS: TestAccConnect_serial/Queue/hoursOfOperationId (102.61s)
--- PASS: TestAccConnect_serial/Queue/dataSource_id (78.81s)
--- PASS: TestAccConnect_serial/Queue/dataSource_name (78.23s)
--- PASS: TestAccConnect_serial/Queue/tags (100.33s)
--- SKIP: TestAccConnect_serial/Queue/maxContacts (0.00s)
--- PASS: TestAccConnect_serial/Queue/outboundCallerConfig (92.28s)
--- PASS: TestAccConnect_serial/Queue/status (91.10s)
--- PASS: TestAccConnect_serial/Queue/quickConnectIds (115.00s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig (1043.85s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/basic (78.66s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisFirehoseConfig_FirehoseARN (116.18s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisStreamConfig_StreamARN (98.08s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketName (231.01s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_BucketPrefix (88.74s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/S3Config_EncryptionConfig (90.97s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/disappears (77.17s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_EncryptionConfig (87.61s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Prefix (87.99s)
--- PASS: TestAccConnect_serial/InstanceStorageConfig/KinesisVideoStreamConfig_Retention (87.43s)
--- PASS: TestAccConnect_serial/UserHierarchyGroup (487.12s)
--- PASS: TestAccConnect_serial/UserHierarchyGroup/basic (89.00s)
--- PASS: TestAccConnect_serial/UserHierarchyGroup/disappears (77.14s)
--- PASS: TestAccConnect_serial/UserHierarchyGroup/updateTags (96.75s)
--- PASS: TestAccConnect_serial/UserHierarchyGroup/parentGroupId (67.49s)
--- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_id (78.67s)
--- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_name (78.07s)
--- PASS: TestAccConnect_serial/HoursOfOperation (510.52s)
--- PASS: TestAccConnect_serial/HoursOfOperation/dataSource_id (77.34s)
--- PASS: TestAccConnect_serial/HoursOfOperation/dataSource_name (77.80s)
--- PASS: TestAccConnect_serial/HoursOfOperation/basic (87.62s)
--- PASS: TestAccConnect_serial/HoursOfOperation/disappears (77.86s)
--- PASS: TestAccConnect_serial/HoursOfOperation/tags (102.29s)
--- PASS: TestAccConnect_serial/HoursOfOperation/config (87.62s)
--- PASS: TestAccConnect_serial/Instance (1028.11s)
--- PASS: TestAccConnect_serial/Instance/basic (88.25s)
--- PASS: TestAccConnect_serial/Instance/directory (713.71s)
--- PASS: TestAccConnect_serial/Instance/saml (120.04s)
--- PASS: TestAccConnect_serial/Instance/dataSource_basic (106.10s)

[github-actions]

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.