Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/aws_connect-tags-update #24864

Merged
merged 8 commits into from
Jul 20, 2022
Merged

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented May 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccConnectHoursOfOperation_serial\|TestAccConnectQueue_serial\|TestAccConnectQuickConnect_serial\|TestAccConnectRoutingProfile_serial\|TestAccConnectSecurityProfile_serial\|TestAccConnectUserHierarchyGroup_serial' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectHoursOfOperation_serial\|TestAccConnectQueue_serial\|TestAccConnectQuickConnect_serial\|TestAccConnectRoutingProfile_serial\|TestAccConnectSecurityProfile_serial\|TestAccConnectUserHierarchyGroup_serial -timeout 180m
=== RUN   TestAccConnectHoursOfOperation_serial
=== RUN   TestAccConnectHoursOfOperation_serial/update_tags
--- PASS: TestAccConnectHoursOfOperation_serial (158.31s)
    --- PASS: TestAccConnectHoursOfOperation_serial/update_tags (158.31s)
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/update_tags
--- PASS: TestAccConnectQueue_serial (138.50s)
    --- PASS: TestAccConnectQueue_serial/update_tags (138.50s)
=== RUN   TestAccConnectQuickConnect_serial
=== RUN   TestAccConnectQuickConnect_serial/update_tags
--- PASS: TestAccConnectQuickConnect_serial (115.75s)
    --- PASS: TestAccConnectQuickConnect_serial/update_tags (115.75s)
=== RUN   TestAccConnectRoutingProfile_serial
=== RUN   TestAccConnectRoutingProfile_serial/update_tags
--- PASS: TestAccConnectRoutingProfile_serial (135.73s)
    --- PASS: TestAccConnectRoutingProfile_serial/update_tags (135.73s)
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/update_tags
--- PASS: TestAccConnectSecurityProfile_serial (119.10s)
    --- PASS: TestAccConnectSecurityProfile_serial/update_tags (119.10s)
=== RUN   TestAccConnectUserHierarchyGroup_serial
=== RUN   TestAccConnectUserHierarchyGroup_serial/update_tags
--- PASS: TestAccConnectUserHierarchyGroup_serial (116.65s)
    --- PASS: TestAccConnectUserHierarchyGroup_serial/update_tags (116.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    784.100s

...
  • Note: For these tests, I commented out the other tests within the serialized tests

@github-actions github-actions bot added service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels May 19, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 19, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver self-assigned this Jul 20, 2022
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

% make testacc TESTS="TestAccConnectUser_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectUser_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectUser_serial (242.10s)
    --- PASS: TestAccConnectUser_serial/updateTags (242.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	243.342s
% make testacc TESTS="TestAccConnectHoursOfOperation_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperation_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectHoursOfOperation_serial (193.44s)
    --- PASS: TestAccConnectHoursOfOperation_serial/updateTags (193.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	195.450s
% make testacc TESTS="TestAccConnectQueue_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueue_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectQueue_serial (172.03s)
    --- PASS: TestAccConnectQueue_serial/updateTags (172.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	173.272s
% make testacc TESTS="TestAccConnectRoutingProfile_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectRoutingProfile_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectRoutingProfile_serial (176.10s)
    --- PASS: TestAccConnectRoutingProfile_serial/updateTags (176.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	177.367s
% make testacc TESTS="TestAccConnectQuickConnect_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnect_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectQuickConnect_serial (162.93s)
    --- PASS: TestAccConnectQuickConnect_serial/updateTags (162.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	164.178s
% make testacc TESTS="TestAccConnectSecurityProfile_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectSecurityProfile_serial (163.55s)
    --- PASS: TestAccConnectSecurityProfile_serial/updateTags (163.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	164.992s
% make testacc TESTS="TestAccConnectUserHierarchyGroup_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectUserHierarchyGroup_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectUserHierarchyGroup_serial (161.92s)
    --- PASS: TestAccConnectUserHierarchyGroup_serial/updateTags (161.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	163.216s
% make testacc TESTS="TestAccConnectUser_serial/updateTags" PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectUser_serial/updateTags'  -timeout 180m
--- PASS: TestAccConnectUser_serial (201.65s)
    --- PASS: TestAccConnectUser_serial/updateTags (201.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	202.943s

@YakDriver YakDriver merged commit bae3dc5 into hashicorp:main Jul 20, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 20, 2022
@GlennChia GlennChia deleted the b-aws_connect-tags-update branch July 21, 2022 02:38
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants