Fix a subtle bug with beanstalkCnamePrefixRegexp #24278
Conversation
Hey, there seems to be a subtle bug with the beanstalkCnamePrefixRegexp where it may match domains that are likely unexpected to be matched e.g. ebamazonaws.com.cn instead of eb.amazonaws.com.cn. I've found this by accident, so please confirm if this commit/PR is correct.
github-actions
bot
added
service/elasticbeanstalk
|
FWIW regex before this PR: and after this PR: (Thx to regexper.com) |
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @disconnect3d 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
ewbankkit
added
bug
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTS=TestAccElasticBeanstalkEnvironment_BeanstalkEnvCNAME_prefix PKG=elasticbeanstalk
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticbeanstalk/... -v -count 1 -parallel 20 -run='TestAccElasticBeanstalkEnvironment_BeanstalkEnvCNAME_prefix' -timeout 180m
=== RUN TestAccElasticBeanstalkEnvironment_BeanstalkEnvCNAME_prefix
=== PAUSE TestAccElasticBeanstalkEnvironment_BeanstalkEnvCNAME_prefix
=== CONT TestAccElasticBeanstalkEnvironment_BeanstalkEnvCNAME_prefix
--- PASS: TestAccElasticBeanstalkEnvironment_BeanstalkEnvCNAME_prefix (425.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk 437.365s
|
@disconnect3d Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Hey, there seems to be a subtle bug with the beanstalkCnamePrefixRegexp where it may match domains that are likely unexpected to be matched e.g. ebamazonaws.com.cn instead of eb.amazonaws.com.cn.
I've found this by accident, so please confirm if this commit/PR is correct before merging it.