feat: Add support for preserve to eks add-on

[stijndehaes]

Signed-off-by: Stijn De Haes stijndehaes@gmail.com

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22226

Output from acceptance testing:

$ make testacc TESTS=TestAccEKSAddon_basic PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSAddon_basic'  -timeout 180m
=== RUN   TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== CONT  TestAccEKSAddon_basic
--- PASS: TestAccEKSAddon_basic (788.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        790.821s

...

[stijndehaes]

Not sure if there is a good way to test this functionality, could use some help with that

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccEKSAddon_ PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2 -run='TestAccEKSAddon_'  -timeout 180m
=== RUN   TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN   TestAccEKSAddon_disappears
=== PAUSE TestAccEKSAddon_disappears
=== RUN   TestAccEKSAddon_Disappears_cluster
=== PAUSE TestAccEKSAddon_Disappears_cluster
=== RUN   TestAccEKSAddon_addonVersion
=== PAUSE TestAccEKSAddon_addonVersion
=== RUN   TestAccEKSAddon_preserve
=== PAUSE TestAccEKSAddon_preserve
=== RUN   TestAccEKSAddon_resolveConflicts
=== PAUSE TestAccEKSAddon_resolveConflicts
=== RUN   TestAccEKSAddon_serviceAccountRoleARN
=== PAUSE TestAccEKSAddon_serviceAccountRoleARN
=== RUN   TestAccEKSAddon_tags
=== PAUSE TestAccEKSAddon_tags
=== RUN   TestAccEKSAddon_DefaultTags_providerOnly
=== PAUSE TestAccEKSAddon_DefaultTags_providerOnly
=== RUN   TestAccEKSAddon_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEKSAddon_DefaultTags_updateToProviderOnly
=== RUN   TestAccEKSAddon_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEKSAddon_DefaultTags_updateToResourceOnly
=== RUN   TestAccEKSAddon_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEKSAddon_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEKSAddon_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEKSAddon_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEKSAddon_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEKSAddon_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEKSAddon_defaultAndIgnoreTags
=== PAUSE TestAccEKSAddon_defaultAndIgnoreTags
=== RUN   TestAccEKSAddon_ignoreTags
=== PAUSE TestAccEKSAddon_ignoreTags
=== CONT  TestAccEKSAddon_basic
=== CONT  TestAccEKSAddon_DefaultTags_providerOnly
--- PASS: TestAccEKSAddon_DefaultTags_providerOnly (776.75s)
=== CONT  TestAccEKSAddon_preserve
--- PASS: TestAccEKSAddon_basic (846.94s)
=== CONT  TestAccEKSAddon_tags
--- PASS: TestAccEKSAddon_preserve (685.48s)
=== CONT  TestAccEKSAddon_serviceAccountRoleARN
--- PASS: TestAccEKSAddon_tags (832.56s)
=== CONT  TestAccEKSAddon_resolveConflicts
--- PASS: TestAccEKSAddon_serviceAccountRoleARN (790.88s)
=== CONT  TestAccEKSAddon_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccEKSAddon_resolveConflicts (782.67s)
=== CONT  TestAccEKSAddon_ignoreTags
--- PASS: TestAccEKSAddon_DefaultTagsProviderAndResource_overlappingTag (667.69s)
=== CONT  TestAccEKSAddon_defaultAndIgnoreTags
--- PASS: TestAccEKSAddon_ignoreTags (716.92s)
=== CONT  TestAccEKSAddon_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccEKSAddon_DefaultTagsProviderAndResource_duplicateTag (1.55s)
=== CONT  TestAccEKSAddon_DefaultTags_updateToResourceOnly
--- PASS: TestAccEKSAddon_defaultAndIgnoreTags (785.23s)
=== CONT  TestAccEKSAddon_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEKSAddon_DefaultTags_updateToResourceOnly (770.00s)
=== CONT  TestAccEKSAddon_Disappears_cluster
--- PASS: TestAccEKSAddon_DefaultTagsProviderAndResource_nonOverlappingTag (801.09s)
=== CONT  TestAccEKSAddon_addonVersion
--- PASS: TestAccEKSAddon_Disappears_cluster (779.64s)
=== CONT  TestAccEKSAddon_disappears
--- PASS: TestAccEKSAddon_addonVersion (798.59s)
=== CONT  TestAccEKSAddon_DefaultTags_updateToProviderOnly
--- PASS: TestAccEKSAddon_disappears (803.46s)
--- PASS: TestAccEKSAddon_DefaultTags_updateToProviderOnly (780.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	6090.507s

[ewbankkit]

@stijndehaes Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.