Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_appintegrations_event_integration #23904

Merged
merged 19 commits into from
May 12, 2022
Merged

r/aws_appintegrations_event_integration #23904

merged 19 commits into from
May 12, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Mar 28, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23903

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccEventIntegration' PKG=appintegrations ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appintegrations/... -v -count 1 -parallel 1  -run=TestAccEventIntegration -timeout 180m
=== RUN   TestAccEventIntegration_basic
=== PAUSE TestAccEventIntegration_basic
=== RUN   TestAccEventIntegration_updateTags
=== PAUSE TestAccEventIntegration_updateTags
=== RUN   TestAccEventIntegration_disappears
=== PAUSE TestAccEventIntegration_disappears
=== CONT  TestAccEventIntegration_basic
--- PASS: TestAccEventIntegration_basic (35.45s)
=== CONT  TestAccEventIntegration_disappears
--- PASS: TestAccEventIntegration_disappears (14.21s)
=== CONT  TestAccEventIntegration_updateTags
--- PASS: TestAccEventIntegration_updateTags (51.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations    101.043s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/appintegrations Issues and PRs that pertain to the appintegrations service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 28, 2022
@GlennChia GlennChia changed the title [WIP] r/aws_appintegrations_event_integration r/aws_appintegrations_event_integration Mar 29, 2022
@GlennChia
fix(appint): add CustomizeDiff to fix update tags
ec74e68 
CustomizeDiff: verify.SetTagsDiff,
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 29, 2022
@GlennChia
Copy link
Collaborator Author

Made a small change and re-ran the test cases (PASS)

$ make testacc TESTARGS='-run=TestAccEventIntegration' PKG=appintegrations ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appintegrations/... -v -count 1 -parallel 1  -run=TestAccEventIntegration -timeout 180m
=== RUN   TestAccEventIntegration_basic
=== PAUSE TestAccEventIntegration_basic
=== RUN   TestAccEventIntegration_updateTags
=== PAUSE TestAccEventIntegration_updateTags
=== RUN   TestAccEventIntegration_disappears
=== PAUSE TestAccEventIntegration_disappears
=== CONT  TestAccEventIntegration_basic
--- PASS: TestAccEventIntegration_basic (36.15s)
=== CONT  TestAccEventIntegration_disappears
--- PASS: TestAccEventIntegration_disappears (14.21s)
=== CONT  TestAccEventIntegration_updateTags
--- PASS: TestAccEventIntegration_updateTags (49.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations    100.369s

@drewmullen
Copy link
Collaborator

real good work! lgtm

$ make testacc TESTARGS='-run=TestAccEventIntegration' PKG=appintegrations ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appintegrations/... -v -count 1 -parallel 1  -run=TestAccEventIntegration -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.43.25
=== RUN   TestAccEventIntegration_basic
=== PAUSE TestAccEventIntegration_basic
=== RUN   TestAccEventIntegration_updateTags
=== PAUSE TestAccEventIntegration_updateTags
=== RUN   TestAccEventIntegration_disappears
=== PAUSE TestAccEventIntegration_disappears
=== CONT  TestAccEventIntegration_basic
--- PASS: TestAccEventIntegration_basic (25.77s)
=== CONT  TestAccEventIntegration_disappears
--- PASS: TestAccEventIntegration_disappears (11.52s)
=== CONT  TestAccEventIntegration_updateTags
--- PASS: TestAccEventIntegration_updateTags (35.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations	76.649s

@breathingdust breathingdust self-assigned this May 12, 2022
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccEventIntegration_' PKG=appintegrations ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appintegrations/... -v -count 1 -parallel 1  -run=TestAccEventIntegration_ -timeout 180m
=== RUN   TestAccEventIntegration_basic
=== PAUSE TestAccEventIntegration_basic
=== RUN   TestAccEventIntegration_updateTags
=== PAUSE TestAccEventIntegration_updateTags
=== RUN   TestAccEventIntegration_disappears
=== PAUSE TestAccEventIntegration_disappears
=== CONT  TestAccEventIntegration_basic
--- PASS: TestAccEventIntegration_basic (23.22s)
=== CONT  TestAccEventIntegration_updateTags
--- PASS: TestAccEventIntegration_updateTags (39.08s)
=== CONT  TestAccEventIntegration_disappears
--- PASS: TestAccEventIntegration_disappears (10.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations	77.564s

Verifying Acceptance Tests skip correctly in GovCloud

make testacc TESTARGS='-run=TestAccEventIntegration_' PKG=appintegrations ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appintegrations/... -v -count 1 -parallel 1  -run=TestAccEventIntegration_ -timeout 180m
=== RUN   TestAccEventIntegration_basic
=== PAUSE TestAccEventIntegration_basic
=== RUN   TestAccEventIntegration_updateTags
=== PAUSE TestAccEventIntegration_updateTags
=== RUN   TestAccEventIntegration_disappears
=== PAUSE TestAccEventIntegration_disappears
=== CONT  TestAccEventIntegration_basic
    acctest.go:615: skipping tests; partition aws-us-gov does not support app-integrations service
--- SKIP: TestAccEventIntegration_basic (1.00s)
=== CONT  TestAccEventIntegration_disappears
    acctest.go:615: skipping tests; partition aws-us-gov does not support app-integrations service
--- SKIP: TestAccEventIntegration_disappears (0.00s)
=== CONT  TestAccEventIntegration_updateTags
    acctest.go:615: skipping tests; partition aws-us-gov does not support app-integrations service
--- SKIP: TestAccEventIntegration_updateTags (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations	5.910s

@breathingdust breathingdust merged commit 5c51c5a into hashicorp:main May 12, 2022
@github-actions github-actions bot added this to the v4.14.0 milestone May 12, 2022
@GlennChia GlennChia deleted the f-aws_appintegrations_event_integration branch May 12, 2022 20:40
@github-actions
Copy link

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewmullen drewmullen drewmullen approved these changes

Assignees

@breathingdust breathingdust

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/appintegrations Issues and PRs that pertain to the appintegrations service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.14.0
Development

Successfully merging this pull request may close these issues.

Add new resource for aws_appintegrations_event_integration
5 participants
@GlennChia @drewmullen @breathingdust @ewbankkit @justinretzolk