Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to refelect PROTOBUF as a supported data_format for the aws_glue_schema resource #23815

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Mar 22, 2022

…supported data_format

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23811

Output from acceptance testing:

$ make testacc TESTS=TestAccGlueSchema_protobuf PKG=glue             (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueSchema_protobuf'  -timeout 180m
=== RUN   TestAccGlueSchema_protobuf
=== PAUSE TestAccGlueSchema_protobuf
=== CONT  TestAccGlueSchema_protobuf
--- PASS: TestAccGlueSchema_protobuf (34.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       34.495s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. labels Mar 22, 2022
@bschaatsbergen bschaatsbergen marked this pull request as draft March 22, 2022 21:15
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 22, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review March 22, 2022 21:28
@bschaatsbergen bschaatsbergen changed the title Add PROTOBUF as a supported data_format for the aws_glue_schema resource Update docs to refelect PROTOBUF as a supported data_format for the aws_glue_schema resource Mar 22, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 23, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlueSchema_protobuf\|TestAccGlueSchema_basic' PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueSchema_protobuf\|TestAccGlueSchema_basic -timeout 180m
=== RUN   TestAccGlueSchema_basic
=== PAUSE TestAccGlueSchema_basic
=== RUN   TestAccGlueSchema_protobuf
=== PAUSE TestAccGlueSchema_protobuf
=== CONT  TestAccGlueSchema_basic
=== CONT  TestAccGlueSchema_protobuf
--- PASS: TestAccGlueSchema_basic (22.60s)
--- PASS: TestAccGlueSchema_protobuf (22.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	27.075s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 265a59e into hashicorp:main Mar 23, 2022
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 23, 2022
@bschaatsbergen bschaatsbergen deleted the add-protobuf-as-supported-glue-schema-data-format branch March 23, 2022 13:12
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support protobuf for aws_glue_schema
2 participants