Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ssm_maintenance_window_task - allow not setting targets #23756

Merged
merged 6 commits into from
Mar 21, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20090
Closes #19396

Output from acceptance testing:

$ make testacc TESTS=TestAccSSMMaintenanceWindowTask_ PKG=ssm

--- PASS: TestAccSSMMaintenanceWindowTask_disappears (37.91s)
--- PASS: TestAccSSMMaintenanceWindowTask_noRole (38.52s)
--- PASS: TestAccSSMMaintenanceWindowTask_emptyNotification (38.69s)
--- PASS: TestAccSSMMaintenanceWindowTask_noTarget (42.96s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters (43.02s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters (57.72s)
--- PASS: TestAccSSMMaintenanceWindowTask_cutoff (63.79s)
--- PASS: TestAccSSMMaintenanceWindowTask_updateForcesNewResource (67.72s)
--- PASS: TestAccSSMMaintenanceWindowTask_description (68.20s)
--- PASS: TestAccSSMMaintenanceWindowTask_basic (68.45s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters (75.11s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters (75.12s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch (90.59s)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Mar 18, 2022
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review March 18, 2022 21:19
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSSMMaintenanceWindowTask_ PKG=ssm ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 3 -run='TestAccSSMMaintenanceWindowTask_'  -timeout 180m
=== RUN   TestAccSSMMaintenanceWindowTask_basic
=== PAUSE TestAccSSMMaintenanceWindowTask_basic
=== RUN   TestAccSSMMaintenanceWindowTask_noTarget
=== PAUSE TestAccSSMMaintenanceWindowTask_noTarget
=== RUN   TestAccSSMMaintenanceWindowTask_cutoff
=== PAUSE TestAccSSMMaintenanceWindowTask_cutoff
=== RUN   TestAccSSMMaintenanceWindowTask_noRole
=== PAUSE TestAccSSMMaintenanceWindowTask_noRole
=== RUN   TestAccSSMMaintenanceWindowTask_updateForcesNewResource
=== PAUSE TestAccSSMMaintenanceWindowTask_updateForcesNewResource
=== RUN   TestAccSSMMaintenanceWindowTask_description
=== PAUSE TestAccSSMMaintenanceWindowTask_description
=== RUN   TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters
=== RUN   TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters
=== RUN   TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters
=== RUN   TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch
=== RUN   TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters
=== PAUSE TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters
=== RUN   TestAccSSMMaintenanceWindowTask_emptyNotification
=== PAUSE TestAccSSMMaintenanceWindowTask_emptyNotification
=== RUN   TestAccSSMMaintenanceWindowTask_disappears
=== PAUSE TestAccSSMMaintenanceWindowTask_disappears
=== CONT  TestAccSSMMaintenanceWindowTask_basic
=== CONT  TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters
=== CONT  TestAccSSMMaintenanceWindowTask_updateForcesNewResource
--- PASS: TestAccSSMMaintenanceWindowTask_updateForcesNewResource (46.21s)
=== CONT  TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters
--- PASS: TestAccSSMMaintenanceWindowTask_basic (47.85s)
=== CONT  TestAccSSMMaintenanceWindowTask_description
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationLambdaParameters (48.45s)
=== CONT  TestAccSSMMaintenanceWindowTask_cutoff
--- PASS: TestAccSSMMaintenanceWindowTask_description (37.72s)
=== CONT  TestAccSSMMaintenanceWindowTask_noRole
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationAutomationParameters (42.67s)
=== CONT  TestAccSSMMaintenanceWindowTask_noTarget
--- PASS: TestAccSSMMaintenanceWindowTask_noRole (19.17s)
=== CONT  TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch
--- PASS: TestAccSSMMaintenanceWindowTask_noTarget (18.56s)
=== CONT  TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters
--- PASS: TestAccSSMMaintenanceWindowTask_cutoff (61.78s)
=== CONT  TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationStepFunctionParameters (26.63s)
=== CONT  TestAccSSMMaintenanceWindowTask_disappears
--- PASS: TestAccSSMMaintenanceWindowTask_disappears (18.63s)
=== CONT  TestAccSSMMaintenanceWindowTask_emptyNotification
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParametersCloudWatch (53.46s)
--- PASS: TestAccSSMMaintenanceWindowTask_taskInvocationRunCommandParameters (62.80s)
--- PASS: TestAccSSMMaintenanceWindowTask_emptyNotification (37.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	196.645s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 214e58c into hashicorp:main Mar 21, 2022
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 21, 2022
@DrFaust92 DrFaust92 deleted the ssm-maint-win branch March 21, 2022 12:28
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants