Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/aws_eks_node_group: Add taints attribute #23452

Conversation

soleares
Copy link
Contributor

@soleares soleares commented Mar 2, 2022

Adds the taints attribute to the aws_eks_node_group data source. It was added to the resource in #19482 but is missing from the data source.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccEKSNodeGroupDataSource PKG=eks

=== RUN   TestAccEKSNodeGroupDataSource_basic
        --- PASS: TestAccEKSNodeGroupDataSource_basic (1384.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        1386.654s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR. labels Mar 2, 2022
@soleares soleares force-pushed the feature/add-eks-node-group-data-source-taints branch from caaa356 to 7176226 Compare March 2, 2022 04:25
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 2, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEKSNodeGroupDataSource_ PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSNodeGroupDataSource_'  -timeout 180m
=== RUN   TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (1052.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1056.341s

@ewbankkit
Copy link
Contributor

@soleares Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 98cd7cb into hashicorp:main Mar 2, 2022
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 2, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants