Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undocumented ipsec.1-aes256 VPN Connection type #23127

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23105.

Unable to test the new value, so just ran a simple regression test:

% make testacc TESTS=TestAccEC2VPNConnection_basic PKG=ec2     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2VPNConnection_basic'  -timeout 180m
=== RUN   TestAccEC2VPNConnection_basic
=== PAUSE TestAccEC2VPNConnection_basic
=== CONT  TestAccEC2VPNConnection_basic
--- PASS: TestAccEC2VPNConnection_basic (407.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	412.032s

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 11, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 11, 2022
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Feb 11, 2022
@ketzacoatl
Copy link
Contributor

ketzacoatl commented Feb 11, 2022

@ewbankkit If you feel confident enough with your test, I can go with that, but if you need (or prefer) a live test before merge, I'd be happy to do so for you. I'm not familiar with using a custom provider, is there a doc I should read for telling my terraform project to use this branch?

EDIT: I see https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/development-environment.md#using-the-provider. I don't have golang installed, but will see if I can figure that out and build the provider.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we give it a go. 🎉

@ewbankkit ewbankkit merged commit d2f3425 into main Feb 11, 2022
@ewbankkit ewbankkit deleted the b-aws_vpn_connection-type branch February 11, 2022 15:41
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 11, 2022
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Feb 11, 2022

Needs backporting to release/3.x.
Done.

ewbankkit added a commit that referenced this pull request Feb 11, 2022
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants