Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_website_configuration: new resource #22648

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (29.72s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (33.03s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (33.37s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (33.38s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (51.82s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (53.22s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (81.73s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 19, 2022
anGie44 added a commit that referenced this pull request Jan 19, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
anGie44 added a commit that referenced this pull request Jan 26, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-website-config-resource branch from 324e23e to fabfc78 Compare January 26, 2022 21:43
@anGie44 anGie44 force-pushed the release/4.x branch 5 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
anGie44 added a commit that referenced this pull request Jan 29, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-website-config-resource branch from fabfc78 to e31bce1 Compare January 29, 2022 00:07
Base automatically changed from release/4.x to main January 31, 2022 22:59
anGie44 added a commit that referenced this pull request Feb 1, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-website-config-resource branch from e31bce1 to 05daf4e Compare February 1, 2022 00:25
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
@gdavison gdavison self-assigned this Feb 2, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One question about the ordering of rules

},
},
"routing_rule": {
Type: schema.TypeSet,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any ordering to the redirect rules? E.g. if I create rules like

`docs/`        => destinationA
`docs/images/` => destinationB

does the order in the generated JSON matter?

Copy link
Contributor Author

@anGie44 anGie44 Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo that's a good question, and i want to say it does matter so this should really be a List 🤦‍♀️ ..also the aws_s3_bucket resource's routing_rules argument doesn't have any

DiffSuppressFunc: verify.SuppressEquivalentJSONDiffs,

which makes me think the List is more appropriate

Copy link
Contributor Author

@anGie44 anGie44 Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to TypeList in a90dcdc to follow what Cloud Control does in its schema 👍

anGie44 added a commit that referenced this pull request Feb 2, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-website-config-resource branch from 05daf4e to aa309bf Compare February 2, 2022 19:02
@anGie44 anGie44 added the new-resource Introduces a new resource. label Feb 2, 2022
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 2, 2022

Output of acceptance tests after a90dcdc:

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (31.34s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (34.80s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (34.82s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (34.86s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (56.15s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (57.64s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (93.74s)

@anGie44 anGie44 requested a review from gdavison February 2, 2022 21:14
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (46.52s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (52.00s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (52.13s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (52.22s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (71.78s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (72.15s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (97.63s)

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants