Resolves issue while creating DynamoDB items #14075

edwardofclt · 2020-07-07T15:35:29Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Resolves issue while creating items in DynamoDB table when the keys created aren't alphanumeric

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccXXX -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.594s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.409s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.792s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/naming	1.619s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apigatewayv2/waiter	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency	0.373s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ec2/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ecs/waiter	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token	0.343s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/guardduty/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/iam/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalytics/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kms/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/neptune/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/rds/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/secretsmanager/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicediscovery/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sfn/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/workspaces/waiter	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/tfawsresource	1.022s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/awsproviderlint	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/helper/awsprovidertype/keyvaluetags	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes	2.115s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001	2.212s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT002	0.326s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSR001	0.412s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSR002	2.086s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/fmtsprintfcallexpr	0.248s [no tests to run]

edwardofclt · 2020-08-25T18:06:41Z

Bump

edwardofclt · 2020-12-15T14:30:07Z

Bumping again.

abased · 2021-07-14T23:32:42Z

what would it take to get this pushed and versioned! my tables have "." in their keys

zhelding · 2021-10-19T16:43:27Z

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

yermulnik · 2022-01-10T15:04:54Z

@edwardofclt Thanks for this PR, I'm really looking forward for it to be merged into TF Provider AWS. Could you please take a look into resolving conflicts (so that it's not an obstacle once Provider maintainers get to this PR). Thank you.

yermulnik · 2022-01-10T15:36:32Z

aws/resource_aws_dynamodb_table_item.go

 	return names
 }

+func cleanDynamoDbKeyName(key string) string {
+	reg, err := regexp.Compile("[^a-zA-Z]+")


I couldn't find what is the exact constraint for the key name. Is it sort of "the key name must start with alpha char only" (rather than "alphanumeric")? If yes, could you please point me in the right direction in the AWS DynamoDB documentation? Thanks.

YakDriver

Thank you 🎉

% make testacc TESTS=TestAccDynamoDBTableItem PKG=dynamodb 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableItem'  -timeout 180m
--- PASS: TestAccDynamoDBTableItem_wonkyItems (25.03s)
--- PASS: TestAccDynamoDBTableItem_withMultipleItems (25.12s)
--- PASS: TestAccDynamoDBTableItem_rangeKey (26.64s)
--- PASS: TestAccDynamoDBTableItem_basic (26.82s)
--- PASS: TestAccDynamoDBTableItem_updateWithRangeKey (36.22s)
--- PASS: TestAccDynamoDBTableItem_update (39.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	40.690s

github-actions · 2022-04-07T22:38:27Z

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-08T02:32:09Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

edwardofclt added 2 commits July 7, 2020 11:21

Resolves issue while creating DynamoDB items

a500d8a

put clean up in its own function

7d27381

edwardofclt requested a review from a team July 7, 2020 15:35

ghost added size/XS Managed by automation to categorize the size of a PR. service/dynamodb Issues and PRs that pertain to the dynamodb service. needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2020

edwardofclt changed the title ~~[WIP] Resolves issue while creating DynamoDB items~~ Resolves issue while creating DynamoDB items Jul 7, 2020

edwardofclt added 3 commits July 7, 2020 12:13

change fatal out for Errorf

a07d608

Errorf using fmt

c4553a6

use log printf instead

4eb6f85

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

Base automatically changed from master to main January 23, 2021 00:58

breathingdust requested a review from a team as a code owner January 23, 2021 00:58

breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2021

yermulnik mentioned this pull request Jan 10, 2022

aws_dynamodb_table_item does not work if one of the field contains a hyphen #10385

Closed

yermulnik reviewed Jan 10, 2022

View reviewed changes

YakDriver self-assigned this Mar 25, 2022

YakDriver added 4 commits March 25, 2022 14:51

Fix conflicts

a6b717f

Add acc test

9d2d304

Add changelog

c0bb9d7

Update documentation

099204e

github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 25, 2022

github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Mar 25, 2022

YakDriver approved these changes Mar 25, 2022

View reviewed changes

YakDriver merged commit 433af92 into hashicorp:main Mar 25, 2022

github-actions bot added this to the v4.8.0 milestone Mar 25, 2022

edwardofclt deleted the fix/alpha-only-keyexpressions branch March 26, 2022 02:13

ewbankkit modified the milestones: v4.8.0, v4.9.0 Mar 27, 2022

github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolves issue while creating DynamoDB items #14075

Resolves issue while creating DynamoDB items #14075

edwardofclt commented Jul 7, 2020 •

edited

Loading

edwardofclt commented Aug 25, 2020

edwardofclt commented Dec 15, 2020

abased commented Jul 14, 2021

zhelding commented Oct 19, 2021

yermulnik commented Jan 10, 2022

yermulnik Jan 10, 2022

YakDriver left a comment

github-actions bot commented Apr 7, 2022

github-actions bot commented May 8, 2022

Resolves issue while creating DynamoDB items #14075

Resolves issue while creating DynamoDB items #14075

Conversation

edwardofclt commented Jul 7, 2020 • edited Loading

Community Note

edwardofclt commented Aug 25, 2020

edwardofclt commented Dec 15, 2020

abased commented Jul 14, 2021

zhelding commented Oct 19, 2021

yermulnik commented Jan 10, 2022

yermulnik Jan 10, 2022

Choose a reason for hiding this comment

YakDriver left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 7, 2022

github-actions bot commented May 8, 2022

edwardofclt commented Jul 7, 2020 •

edited

Loading