-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Modify CallFunction implementations #1316
Conversation
Reference: hashicorp/terraform-plugin-go#380 Reference: https://developer.hashicorp.com/terraform/plugin/framework/migrating The next versions of the plugin protocol (5.5/6.5) include support for provider defined functions. The terraform-plugin-sdk Go module will not be receiving this feature, however this Go module must be updated to handle the new RPC with errors. Provider developers can implement provider defined functions by introducing terraform-plugin-mux and using their terraform-plugin-sdk based providers in combination with a terraform-plugin-framework provider that contains the provider defined functions.
@@ -14,7 +14,7 @@ require ( | |||
github.com/hashicorp/logutils v1.0.0 | |||
github.com/hashicorp/terraform-exec v0.20.0 | |||
github.com/hashicorp/terraform-json v0.21.0 | |||
github.com/hashicorp/terraform-plugin-go v0.21.0 | |||
github.com/hashicorp/terraform-plugin-go v0.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running go get github.com/hashicorp/terraform-plugin-go
results in the addition of the following entry to go.mod
:
toolchain go1.21.6
Which would result in an analogous CI failure to that seen on terraform-plugin-mux
Given that our CI runs both Go 1.20
and 1.21
, I removed this directive, but perhaps this should be handled differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing it is okay for now -- or can just let Dependabot own the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Reference: hashicorp/terraform-plugin-go#380
Reference: https://developer.hashicorp.com/terraform/plugin/framework/migrating
Reference: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175
The next versions of the plugin protocol (5.5/6.5) include support for provider defined functions. The terraform-plugin-sdk Go module will not be receiving this feature, however this Go module must be updated to handle the new RPC with errors.
Provider developers can implement provider defined functions by introducing terraform-plugin-mux and using their terraform-plugin-sdk based providers in combination with a terraform-plugin-framework provider that contains the provider defined functions.