Fix panic in IsFullyKnown. #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Value.IsFullyKnown would panic if the type of the value was an aggregate type (List, Set, Tuple, Map, or Object) and if that value itself was null. This adds tests to reproduce those panics and a minor change to IsFullyKnown that prevents the panics.
alexsomesan
reviewed
Mar 25, 2021
kmoe
approved these changes
Mar 31, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling Value.IsFullyKnown would panic if the type of the value was an
aggregate type (List, Set, Tuple, Map, or Object) and if that value
itself was null.
This adds tests to reproduce those panics and a minor change to
IsFullyKnown that prevents the panics.