Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade armon/go-metrics to hashicorp/go-metrics #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dentrax
Copy link

@Dentrax Dentrax commented Jul 28, 2024

Fixes #707

Fixes hashicorp#707

Signed-off-by: Dentrax <furkan.turkal@hotmail.com>
@Dentrax Dentrax requested a review from a team as a code owner July 28, 2024 11:13
@Dentrax Dentrax requested review from skpratt and removed request for a team July 28, 2024 11:13
Copy link

hashicorp-cla-app bot commented Jul 28, 2024

CLA assistant check
All committers have signed the CLA.

@rboyer
Copy link
Member

rboyer commented Jul 29, 2024

Quoting @jmurret's reply on another nearly identical PR:

Hi all, we will post a more detailed thread on why this is complicated, but the short gist is that this change has to be consistently updated across the dependency chains of libraries used in an application. go-metrics relies on a singleton sink in global state. If any applications have a mix of armon metrics and hashicorp due to underlying dependencies not aligning on only one of them, metrics will be split among different sinks in the global state.
This change has to be coordinated with changing and releasing this dependency across multiple libraries and applications in a thoughtful way. This PR is taking longer than expected due to the prioritization and coordination of those efforts to ensure a smooth transition. Thank you for your patience and understanding.

@skpratt skpratt requested review from jmurret and removed request for skpratt August 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please, Upgrade armon/go-metrics to hashicorp/go-metrics
2 participants