-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Success Pull Request Comment is not send, while errors are working fine #637
Comments
@0ptaq0 that might be a bug :) |
There are many sfdx-hardis features embedded within hardis:project:deploy:sources:dx, including JIRA ones. hardis:source:deploy currently only embeds the errors comment. The corresponding call of your use case would be the following:
you would also need to define the following variables in your gitlab-ci.yml variables:
SFDX_DEPLOY_WAIT_MINUTES=300
PACKAGE_XML_TO_DELETE=dx-delta/destructiveChanges/destructiveChanges.xml Please can you try to check if it works on your project ? :) |
Additional note: after merge, if you use the following script, you will benefit of QuickDeploy :)
|
Thank you Nicolas, JIRA integration now works like a charm :) Regarding I have only one issue with destructive changes, the env var
My flow looks like this:
SFDX Git Delta creates a diff package and package.xml + destructiveChanges.xml which I then archive and pass to sfdx-hardis. Also as mentioned above I am using custom CICD and embedded sfdx-hardis so I do not have any As a workaround, I can also check if destructive Changes are not empty and then call yet another sfdx deployment command, but the best would be to fit everything in one shot ;) |
@0ptaq0 do you know that sfdx-git-delta is also embedded within sfdx-hardis and project:source:deploy:dx ? :) https://sfdx-hardis.cloudity.com/salesforce-ci-cd-config-delta-deployment/ I'm wondering if you are not trying to reproduce the standard sfdx-hardis pipeline :) https://github.com/hardisgroupcom/sfdx-hardis/blob/main/defaults/ci/.gitlab-ci.yml https://github.com/hardisgroupcom/sfdx-hardis/blob/main/defaults/ci/.gitlab-ci-config.yml Can you compare with your pipeline ? I feel the only difference is that
If you want, please share your gitlab-ci.yml and i'll tell you :) |
Hi Nicolas, I made it work to some extent. My commands are:
I have a slight difference compared to your standard sfdx-hardis pipeline, as you do merge 1st, and 2nd is a quick deploy, while I want to do the opposite - 1st deploy if that succeeds, merge the Pull/Merge Request. Is there any chance to add some flag in the future for sfdx-hardis to support this "opposite" approach that I am using? I am not a Typescript expert so I don't feel comfortable with opening my Pull Request to sfdx-hardis to support that ;) |
@0ptaq0 i'm not a DevOps expert (anyway, not more than I am a Salesforce expert), but deploying before merging the Pull Request feels like a really strange pattern ^^ Imagine, for example if you have conflicts you'll have deployed in target org before merging them If you need deployment success messages, with current pattern you can already have them with Slack/Teams/Email notifications I'm ok with exotic behaviors if they are triggered only in case some specific parameter or env var is set, but I'm not sure i've understood everything that you need, maybe you'd like to post a schema to explain ? :) ( like a draw.io for example ) |
When there is a conflict no validation, or deployment will be triggered. |
@0ptaq0 great, don't bother detailing a lot, just a few boxes with arrows between them will do :) And I never had 80 developers in parallel on the same project (we are mostly middle market at Cloudity), so I might learn a thing a 2 from your approach for when we'll catch bigger accounts :) |
Ok I get it, interesting :) So basically, all you need is to be able to get the "QuickDeploy" deploymentId from the current MR and not try to get it in the latest merged MR comments ? :) |
Haha, yes, but not only, I also see some notifications after deployment, like JIRA labels, MR comments after deployment etc. |
hmmmm I'll see what I can do, while you use hardis:project:deploy:dx I think we will find a way if you add some variable SFDX_HARDIS_DEPLOY_BEFORE_MERGE=true ^^ |
Oh yes, that would be perfect, thanks in advance Nicolas! |
let's keep it open, that's where I'll ask you for some tests :) |
@0ptaq0 if we are lucky I think that #649 could do the job for Quick Deploy + Slack / Teams / Jira notifications :) Please can you test with sfdx-hardis@alpha and tell me if it works ? :)
Define SFDX_HARDIS_DEPLOY_BEFORE_MERGE=true in your env vars :) |
Wow! Many Thanks @nvuillam for such a quick action. THANKS AGAIN!! |
@0ptaq0 i'm glad your use case works :) Modular architecture was almost ready to handle your use case (that you described very well), so it wasn't that long :) I'll release the update in an official version tonight ^^ Ps: if you like to post, don't hesitate to post about sfdx-hardis 😇 |
No worries, when I will be creating some tip or post for BeyondTheCloud I will surely mention sfdx-hardis feature suggested, feature implemented in hours - I love it ;) |
@0ptaq0 Oh you are from BeyondTheCloud 🤩 Would be great to appear on it indeed 🙃 |
@0ptaq0 released in https://github.com/hardisgroupcom/sfdx-hardis/releases/tag/v4.46.0 :) (latest) Have fun :) |
Thank you @nvuillam Great to hear you like BeyondTheCloud, we trying our best :D |
I am using sfdx hardis in my custom Gitlab pipeline.
Pipelines are running bounded to Merge Requests, 'Enable merged results pipelines' option is enabled >>
"This pipeline ran on the contents of the merge request combined with the contents of the target branch"
I have added following env variables:
My validation/deployment command looks almost the same, only difference is
--checkonly
flag:During deployment I would expect some success message posted to Merge Request comment and optionally to related JIRA in MR's description, but I am getting below:
However, posting error comments works just fine:
And then I can see a comment with great tips on how to solve errors ;)
Also, nothing is posted to JIRA but that's a minor item, I would just need a success comment to Merge Request at this moment.
What am I missing?
The text was updated successfully, but these errors were encountered: