Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some alter-table methods are unavailable at migration #491

Open
saiidalhalawi opened this issue Jun 29, 2018 · 2 comments
Open

Some alter-table methods are unavailable at migration #491

saiidalhalawi opened this issue Jun 29, 2018 · 2 comments
Labels

Comments

@saiidalhalawi
Copy link

Hi, I use following versions.

  • hanami (1.1.1)
  • sequel (4.49.0)

The document says set_column_allow_null is available at migration, but I've encountered undefined method error.

Hanami::Model.migration do
  change do
    set_column_allow_null :users, :address
  end
end
undefined method `set_column_allow_null' for #<Sequel::Mysql2::Database:0x00007f0b48099660>
Did you mean?  set_column_default

In addition, some other methods, like set_column_not_null or add_unique_constraint, are same.
It seems to be good the document is fixed, because I think these methods might be dispensable.

Do you think of it?
Thanks.

@cllns
Copy link
Member

cllns commented Jun 29, 2018

Thanks for opening this. I found this bug a year ago but forgot about it :(

See: #387 and #391

@cllns cllns added the bug label Jun 29, 2018
@makketagg
Copy link

@cllns guide was fixed. Whoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants