Skip to content

Commit

Permalink
fix: remove set_minimum_degree
Browse files Browse the repository at this point in the history
  • Loading branch information
han0110 committed Oct 16, 2023
1 parent 449e087 commit a034d09
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions halo2_proofs/src/plonk/circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1795,13 +1795,9 @@ impl<F: Field> ConstraintSystem<F> {
.max()
.unwrap();

let required_degree = std::cmp::max(max_gate_degree, max_single_lookup_degree);
let required_degree = (required_degree as u64 - 1).next_power_of_two() as usize;

self.set_minimum_degree(required_degree + 1);

// safe to unwrap here
let minimum_degree = self.minimum_degree.unwrap();
let minimum_degree = std::cmp::max(max_gate_degree, max_single_lookup_degree);
// TODO: Find the best degree that needs least commitment
// let minimum_degree = (minimum_degree as u64 - 1).next_power_of_two() as usize + 1;

let mut lookups: Vec<_> = vec![];
for v in self.lookups_map.values() {
Expand Down

0 comments on commit a034d09

Please sign in to comment.