Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive AOT Test Suite #5047

Open
shoaibkamil opened this issue Jun 17, 2020 · 4 comments
Open

Comprehensive AOT Test Suite #5047

shoaibkamil opened this issue Jun 17, 2020 · 4 comments
Labels
build Issues related to building Halide and with CI

Comments

@shoaibkamil
Copy link
Contributor

Continuing discussion from #5040, Halide should have an AOT test suite for testing on devices/environments that don't support JIT. This could be a subset of the existing tests that use JIT compilation.

@shoaibkamil
Copy link
Contributor Author

To make it easier to run on iOS and Android-style devices, I additionally propose this suite should have a single executable entrypoint; that makes it so that we just have to launch one executable, rather than one per test.

@steven-johnson
Copy link
Contributor

single executable entrypoint

This is an idea worth exploring, but with our current runtime setup it may be impractical or impossible, since some tests require custom runtime overrides, and the weak-linkage-replacement approach we have now makes that hard to do. (It also might make turnaround time unpleasant.)

@shoaibkamil
Copy link
Contributor Author

I think it'll be impossible if we try to do it for all tests, but I believe there's a large subset for which a single executable would help. I'm going to explore some possibilities and report back.

@shoaibkamil
Copy link
Contributor Author

It looks like it wouldn't actually be that necessary to have a single executable, as running via command line on a connected device is fast enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to building Halide and with CI
Projects
None yet
Development

No branches or pull requests

3 participants