Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the hafs_obs_prep job script to handle zero bytes gfs.tCCz.prepbufr file #244

Open
BinLiu-NOAA opened this issue Nov 30, 2023 · 1 comment
Assignees
Labels
Bugzilla Operational HAFS bugzilla items enhancement New feature or request

Comments

@BinLiu-NOAA
Copy link
Collaborator

BinLiu-NOAA commented Nov 30, 2023

Description

Provide a clear and concise description of the requested feature/capability.
From NCO SPA: In the HAFS v1.0 IT tests, tested the hafs_obs_prep job with a gfs.tCCz.prepbufr file with zero bytes. Expected the job should failed with error message, similar as HWRF jhwrf_bufrprep job, “CRITICAL: HWRF bufrprep is aborting:
gfs.t00z.prepbufr: is non-existant or empty”. But the hafs_obs_prep job proceeded with failure nor error message.

Please look into this at the next upgrade to improve the hafs_obs_prep job to properly check and fail when the gfs.tCCz.prepbufr file has zero bytes.

Proposed solution

How should the new feature/capability be added? If you have thoughts on the implementation strategy, please share them here.

Status (optional)

Do you (or a colleague) plan to work on adding this feature?

Related to (optional)

Directly reference any related issues or PRs in this or other repositories, and describe how they are related. Examples:

  • fixed by hafs-community/hafs/pull/<pr_number>
@BinLiu-NOAA BinLiu-NOAA added enhancement New feature or request Bugzilla Operational HAFS bugzilla items labels Nov 30, 2023
@BinLiu-NOAA BinLiu-NOAA self-assigned this Jan 11, 2024
@BinLiu-NOAA
Copy link
Collaborator Author

Updated exhafs_obs_prep.sh so that it checks if the gfs prepbufr file exists and is non-empty, otherwise it exits with a "FATAL ERROR" (see ed0d888).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugzilla Operational HAFS bugzilla items enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant