Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HAFS scripts to use cpreq and cpfs production utilities #240

Open
BinLiu-NOAA opened this issue Nov 30, 2023 · 1 comment
Open
Assignees
Labels
Bugzilla Operational HAFS bugzilla items enhancement New feature or request

Comments

@BinLiu-NOAA
Copy link
Collaborator

BinLiu-NOAA commented Nov 30, 2023

Description

Provide a clear and concise description of the requested feature/capability.
From NCO SPA: Improve the HAFS scripts to use cpreq and cpfs production utilities at the next upgrade.

Most of the HAFS v1.0 scripts are using $NCP defined in the ush/hafs_runcmd.sh.inc to copy the data files. Suggest to define the define of NCP as the following that allows $NCP to be redefined and used in different scripts -
NCP=${NCP:-"/bin/cp -p "}

For example, allow jobs to use "cpreq" utility to copy needed input data or use "cpfs" to copy output data files to $COMOU. For example, define NCP="cpfs" in jhafs_gempak.ecf file.

Please refer to WCOSS implementaion doc, page 8 for usage of cpreq and cpfs -

  • cpreq is used to copy files that are essential to an application.
  • cpfs is used to copy files while ensuring that the whole file has been copied before it becomes accessible so that downstream applications will not attempt to copy or read a partial file.

Proposed solution

How should the new feature/capability be added? If you have thoughts on the implementation strategy, please share them here.

Status (optional)

Do you (or a colleague) plan to work on adding this feature?

Related to (optional)

Directly reference any related issues or PRs in this or other repositories, and describe how they are related. Examples:

  • fixed by hafs-community/hafs/pull/<pr_number>
@BinLiu-NOAA BinLiu-NOAA added enhancement New feature or request Bugzilla Operational HAFS bugzilla items labels Nov 30, 2023
@BinLiu-NOAA BinLiu-NOAA self-assigned this Jan 11, 2024
@BinLiu-NOAA
Copy link
Collaborator Author

Based on the NCO SPA's suggestion, the NCP and FCP variables are defined in ush/hafs_runcmd.sh.inc. Under NCO environment, NCP is set as cpreq, FCP is set as cpfs. If desired, they can be easily override at ecf or jjob levels. Meanwhile, the jobs/scripts/ush scripts were improved to use the NCP and FCP commands properly. Please see commit: e4cf12a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugzilla Operational HAFS bugzilla items enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant