[travis] Use a gcc/g++-based compiler for node native compilation. #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to work around the LLVM apt site going offline (source: http://lists.llvm.org/pipermail/llvm-dev/2016-May/100303.html) which caused the Travis builds to all fail (source travis-ci/apt-source-safelist#279). We'll use the gcc/g++ alternative toolchain from the [docs](https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Node.js-v4-(or-io.js-v3)-compiler-requirements). Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
|
By analyzing the blame information on this pull request, we identified @smith, @adamhjk and @cwebberOps to be potential reviewers |
|
📌 Commit ec10e7d has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 1, 2016
This change is to work around the LLVM apt site going offline (source: http://lists.llvm.org/pipermail/llvm-dev/2016-May/100303.html) which caused the Travis builds to all fail (source travis-ci/apt-source-safelist#279). We'll use the gcc/g++ alternative toolchain from the [docs](https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Node.js-v4-(or-io.js-v3)-compiler-requirements). Signed-off-by: Fletcher Nichol <fnichol@nichol.ca> Pull request: #599 Approved by: reset
|
@reset let's hope this works, right?
|
|
|
|
☀️ Test successful - travis |
Closed
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change is to work around the LLVM apt site going offline (source: http://lists.llvm.org/pipermail/llvm-dev/2016-May/100303.html) which caused the Travis builds to all fail (source travis-ci/apt-source-safelist#279). We'll use the gcc/g++ alternative toolchain from the [docs](https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Node.js-v4-(or-io.js-v3)-compiler-requirements). Signed-off-by: Fletcher Nichol <fnichol@nichol.ca> Pull request: #599 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to work around the LLVM apt site going offline (source: http://lists.llvm.org/pipermail/llvm-dev/2016-May/100303.html) which caused the Travis builds to all fail (source: travis-ci/apt-source-safelist#279). We'll use the gcc/g++ alternative toolchain from the docs.