Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New found vulnerabilities in h2 #1410

Closed
AlexanderNikitin-Smartbear opened this issue Aug 29, 2018 · 9 comments
Closed

New found vulnerabilities in h2 #1410

AlexanderNikitin-Smartbear opened this issue Aug 29, 2018 · 9 comments

Comments

@AlexanderNikitin-Smartbear

Hello,
In the past, we scanned artifact h2, version 1.4.197 with Veracode (#816), but the engine of Veracode is updated, so it've found some new vulnerabilities. The report is attached.
h2.pdf

@katzyn
Copy link
Contributor

katzyn commented Aug 29, 2018

It looks like this tool was designed (or configured) for web applications and similar products.

Warnings like

J2EE Bad Practices: Direct Management of Connections

Information Exposure Through Sent Data

and probably some others are not applicable to database engine.

Such reports are not very useful. They may find something that needs attention, but it's better to filter out at least such tests that obviously should not be used to test a database engine.

@IlyaAvdeev
Copy link

what about Very High (OS Command Injection) and High (SQL Injection). In your response you paid attention to som strange Low vulnerabilities only.

@katzyn
Copy link
Contributor

katzyn commented Aug 30, 2018

I intentionally ignored false positives, some amount of them is a normal situation for any automated testing system.

Did you check sources or only the report?

@IlyaAvdeev
Copy link

I'm not comfortable with your source code enough and not sure I can assess the potential vulnerabilities correctly. That's why we ask input from the lib developers.

@katzyn
Copy link
Contributor

katzyn commented Aug 30, 2018

If you want detailed reply I suggest you to configure your testing system properly for each specific product that you test to avoid huge amount of incorrect warnings. Some software that uses a database and database engine itself work with SQL in very different way.

Also your report is abused with unrelated information. It would be easy to read it without working time predictions and large descriptions of obvious things. Somebody may want this information, but developers are usually not.

@IlyaAvdeev
Copy link

Do you confirm all found vulnerabiliities are false positive?

@katzyn
Copy link
Contributor

katzyn commented Aug 30, 2018

Most of them definitely are, but I might have missed something.

For example, when names and string literals are properly quoted your system reports a SQL injection anyway. I don't know how to avoid it, because different products use different ways to quote them. (Usage of prepared statements is not always possible.)

Access to file system from methods that are designed to do it and that require appropriate permissions from end user is not a vulnerability.

DB server works with network, why this is detected as a problem?

Warnings about insufficient entropy in places that don't work with cryptography are not relevant.

And so on.

@IlyaAvdeev
Copy link

Can you please more speicific? Please list the points which are 100% false positive?

@grandinj
Copy link
Contributor

We have already explained and wasted enough time on this, please do your own work properly before wasting our time. Especially since this appears to be a commercial project, I do not see why we need to act to unpaid QA for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants