Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regis URL #352

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Fix regis URL #352

merged 5 commits into from
Jun 20, 2024

Conversation

rubencalje
Copy link
Collaborator

@rubencalje rubencalje commented Jun 17, 2024

This PR simplifies the REGIS- and GeoTOP-urls, to the openda[-server named on https://www.dinoloket.nl/modelbestanden-aanvragen/netcdf. It also sets the version of the netcdf4 package to below 1.70, because of issue #353.

@rubencalje rubencalje marked this pull request as ready for review June 20, 2024 10:04
@dbrakenhoff dbrakenhoff merged commit b7fb73f into dev Jun 20, 2024
4 checks passed
@dbrakenhoff dbrakenhoff deleted the fix_regis_url branch June 20, 2024 12:19
@bdestombe
Copy link
Collaborator

Hi Ruben,
Why did you limit the netCDF4 versions only in the CI and the creation of the documentation, and not in the main dependency list of nlmod (

"netcdf4>=1.6.3",
)?

@rubencalje
Copy link
Collaborator Author

Hi Ruben,
Why did you limit the netCDF4 versions only in the CI and the creation of the documentation, and not in the main dependency list of nlmod (

"netcdf4>=1.6.3",
)?

Because I could not reprise the error on my Windows pc, so I thought maybe it is only a linux-problem. And I did not want to restrict package versions too much.

@bdestombe
Copy link
Collaborator

Ah but what about Davíd and the few other crazy Linux users? ;)

In my case, I use nlmod as a dependency and the CI of my scripts are failing because of it. To me it would have made sense if it would have been added to the main dependecy list of nlmod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants