Fix remove layer #307
Merged
Fix remove layer #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail unrelated to thsi pr |
OnnoEbbens
requested changes
Dec 18, 2023
| # lower the top to the second layer | ||
| ds["top"] = ds["botm"].loc[layers[1]] | ||
| # lower the top to the botm of the first layer | ||
| ds["top"] = ds["botm"].loc[layers[0]] |
There was a problem hiding this comment.
I think the docstring needs to be changed. It says now: "Removes a layer from a Dataset, without changing elevations of other layers". The last part is (and was already) incorrect.
There was a problem hiding this comment.
I think the docstring is (still) correct. The top and botm of other layers are not changed. Only when the top layer is removed, the top of the new top layer (that used to be the second layer) is set to the variable top. The top of the second layer is not changed, only the way it is represented in ds changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first layer is removed, the top needs to be set on the botm of this layer, not on the botm of the second layer.