Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split layer ds minor changes #295

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Split layer ds minor changes #295

merged 5 commits into from
Nov 27, 2023

Conversation

bdestombe
Copy link
Collaborator

@bdestombe bdestombe commented Nov 22, 2023 •
edited
Loading

Merge after #294

@bdestombe bdestombe closed this Nov 22, 2023
@bdestombe bdestombe reopened this Nov 22, 2023
@bdestombe bdestombe changed the base branch from main to dev November 22, 2023 08:39
@bdestombe bdestombe changed the base branch from dev to Add-gridtype-attribute-to-REGIS-construction November 22, 2023 08:40
@bdestombe bdestombe marked this pull request as ready for review November 24, 2023 11:28
@bdestombe bdestombe mentioned this pull request Nov 24, 2023
Closed
@bdestombe bdestombe linked an issue Nov 24, 2023 that may be closed by this pull request
to_model_ds() always removes nan layers #299
Closed
dbrakenhoff
dbrakenhoff approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but can also be solved in another issue. Up to you.

Base automatically changed from Add-gridtype-attribute-to-REGIS-construction to dev November 24, 2023 13:37
@bdestombe bdestombe mentioned this pull request Nov 27, 2023
Open
@bdestombe bdestombe merged commit ad60034 into dev Nov 27, 2023
2 checks passed
@bdestombe bdestombe deleted the split_layer_ds-minor-changes branch November 27, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrakenhoff dbrakenhoff dbrakenhoff approved these changes

@rubencalje rubencalje Awaiting requested review from rubencalje

@OnnoEbbens OnnoEbbens Awaiting requested review from OnnoEbbens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_model_ds() always removes nan layers
2 participants
@bdestombe @dbrakenhoff