-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to version 0.7.0 #273
Conversation
- use chunks and dask delayed to keep memory usage efficient - get_geotop now gets raw data - add deprecationwarning to get_geotop_raw_within_extent()
- now takes geotop_ds as input to convert to layers (not extent)
- do not use sortby but check diff of y dimension and flip if necessary
- use .values instead of .data to load data into memory if using dask - undo onno changes for now w missing strat code
- add kwarg delayed, if False, load data into memory, else return data array with delayed dask arrays - add kwarg chunked, if True, chunk data array with chunks="auto" - add x,y data to vertex grid data array
- add function name in all cases - add line number when level is DEBUG
- use .values to deal with dask arrays - use get_geotop - update docstring
* fix for #199 * fix * return da in some situations --------- Co-authored-by: Ruben Caljé <r.calje@artesia-water.nl>
Small fix for Error: Assigning CRS to a GeoDataFrame without a geometry column is not supported
when it is None. The default is None. | ||
finf :float, str or array-like | ||
The applied infiltration rate of the UZF cell (:math:`LT^{-1}`). When passed as | ||
string, the array is obtained from ds. The default is "recharge". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to name this "recharge" by default or should it be precipitation? Recharge implies we already include evaporation somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also set the default to None so the user has to decide what data should be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot's of great improvements :)! I made a few minor comments, nothing major. These could also be converted into issues to deal with in a next version.
I think we should just use our admin powers to ignore issues on codacy, or somehow add some of the issues it raises to the ignore list. Most of them aren't really an issue or worth fixing. |
Has #261 been fixed yet? It would be good to get that one done before this release I think. |
I fixed most of the codacy errors. Some ideas/remarks/questions:
|
Suddenly a new check: |
The ~ issues can be ignored. I'm not sure how to avoid the check being triggered for these cases. |
* Add nhi.py and test * Improve nhi.py * Small changes (unrelated to buisdrainage) * Add some options to modpath * Fix Issue #261 * Fix codacy stuff and improve some testst * Fix the unit of the conductance of buisdrainage * Fix test * some minor fixes - added one docstring, fixed some typos, sort imports * Add docstrings to nhi * Replace seasons by winter_name and summer_name in surface_water.py * Remove warnings and and output from unsaturated notebooks --------- Co-authored-by: Davíd Brakenhoff <d.brakenhoff@artesia-water.nl>
No description provided.