Incomplete knmi ts breaks get_recharge function #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution provided by Davíd. By setting fill_missing_obs missing values are filled with nearby time series
|
I updated the fill_missing_obs functionality in hydropandas this week. It does not check if de Bilt has measurements anymore, if this is not needed (when no data needs to be filled). So we maybe need to increase the hydropandas version in the next nlmod release (if the new hydropandas has been released). |
|
Also, evaporation-measurements were not filled in Hydropandas. This has been fixed in a PR last week: ArtesiaWater/hydropandas#157 |
|
I've updated hydropandas and pinned the version in the requirements of nlmod. I would like to merge this PR and release a new nlmod version asap. After that we can transfer nlmod to a new organisation without any open PR's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution provided by Davíd.
Missing values are filled with nearby time series by setting fill_missing_obs to True