improve plotting in notebooks #224 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dbrakenhoff
commented
Aug 24, 2023
dbrakenhoff
commented
- use nlmod.plot.get_map() where possible
- simplify plotting with nlmod.plot.map_array()
- other nb improvements (e.g. descriptions, text, etc).
- rename kwarg background to backgroundmap in get_map
- improve default axis ticks in get_map
- some typos
- rename layer coord to source_layer in get_concentration_at_gw_surface()
- use nlmod.plot.get_map() where possible - simplify plotting with nlmod.plot.map_array() - other nb improvements (e.g. descriptions, text, etc). - rename kwarg background to backgroundmap in get_map - improve default axis ticks in get_map - some typos - rename layer coord to source_layer in get_concentration_at_gw_surface()
black formatting
rubencalje
approved these changes
Aug 25, 2023
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.