Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop overwriting kh and kv of geotop in add_geotop_to_regis_layers #243

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Stop overwriting kh and kv of geotop in add_geotop_to_regis_layers #243

merged 3 commits into from
Aug 25, 2023

Conversation

rubencalje
Copy link
Collaborator

No description provided.

@rubencalje rubencalje mentioned this pull request Aug 24, 2023
Closed
dbrakenhoff
dbrakenhoff reviewed Aug 24, 2023
View reviewed changes
nlmod/read/regis.py Outdated Show resolved Hide resolved
dbrakenhoff
dbrakenhoff approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, after fixing of typos and adding anisotropy definition in docstring.

@dbrakenhoff dbrakenhoff self-requested a review August 25, 2023 07:57
dbrakenhoff
dbrakenhoff requested changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing KeyError kv

@dbrakenhoff dbrakenhoff merged commit 3e61b49 into dev Aug 25, 2023
2 checks passed
@dbrakenhoff dbrakenhoff deleted the stop_overwriting_kh_and_kv_geotop branch August 25, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrakenhoff dbrakenhoff dbrakenhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubencalje @dbrakenhoff