Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling data when building flopy packages from model dataset #188

Merged
merged 15 commits into from
Jun 7, 2023
Merged

Handling data when building flopy packages from model dataset #188

merged 15 commits into from
Jun 7, 2023

Commits on Jun 5, 2023

  1. improve data variable handling: 

    - use _get_value_from_ds_attr and _get_value_from_data_var
- deprecation warning for ghb/drn `da_name=` kwarg
- rename 'chd' arg to 'mask' (with deprecationwarning)
    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    fd6e2a6 View commit details
    Browse the repository at this point in the history

  2. move _get_value_from_ds_* funcs to util

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    df5f6e6 View commit details
    Browse the repository at this point in the history

  3. move _get_value_from_ds_* funcs to util

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    aa09de2 View commit details
    Browse the repository at this point in the history

  4. rename "_peil" to "_stage" data var for rws data

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c1f40f4 View commit details
    Browse the repository at this point in the history

  5. line length

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    275e9f2 View commit details
    Browse the repository at this point in the history

  6. shorten func names 

    - since we use ds as a common abbreviation for dataset
    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    493e2bf View commit details
    Browse the repository at this point in the history

  7. add tests for _get_value_from_ds_*

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    f31c349 View commit details
    Browse the repository at this point in the history

  8. update notebooks

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    64ca08f View commit details
    Browse the repository at this point in the history

  9. update tests

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    756edc0 View commit details
    Browse the repository at this point in the history

  10. isort

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    dc4c917 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/dev' into ghb_drn_params

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    71eacd0 View commit details
    Browse the repository at this point in the history

  12. fix import

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    19e8330 View commit details
    Browse the repository at this point in the history

  13. codacy

    @dbrakenhoff
    dbrakenhoff committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a528aee View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'dev' into ghb_drn_params

    @rubencalje
    rubencalje authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ca635e5 View commit details
    Browse the repository at this point in the history

  2. Remove da_name from nlmod.gwf.ghb in transport-notebook

    @rubencalje
    rubencalje committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2a124e9 View commit details
    Browse the repository at this point in the history