Knmi stations #174
Merged
Knmi stations #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slow determination of stations (locations.geo.get_nearest_point) is removed
rubencalje
added a commit
that referenced
this pull request
May 8, 2023
* Add option to only use most common station Slow determination of stations (locations.geo.get_nearest_point) is removed * solve minor bug and add test for most_common_station=True * Set gridgen files in a separate directory. Solves issue #158 * minor changes * Make most_common_station work with structured grids as well * Create gridgen directory when it does not exist * Solve fiona.errors.DriverError: not recognized as a supported file format. * Remove rasterstats as a dependency for tests and docs * Codacy stuff
dbrakenhoff
pushed a commit
that referenced
this pull request
May 9, 2023
* Add option to only use most common station Slow determination of stations (locations.geo.get_nearest_point) is removed * solve minor bug and add test for most_common_station=True * Set gridgen files in a separate directory. Solves issue #158 * minor changes * Make most_common_station work with structured grids as well * Create gridgen directory when it does not exist * Solve fiona.errors.DriverError: not recognized as a supported file format. * Remove rasterstats as a dependency for tests and docs * Codacy stuff
dbrakenhoff
pushed a commit
that referenced
this pull request
May 9, 2023
* Add option to only use most common station Slow determination of stations (locations.geo.get_nearest_point) is removed * solve minor bug and add test for most_common_station=True * Set gridgen files in a separate directory. Solves issue #158 * minor changes * Make most_common_station work with structured grids as well * Create gridgen directory when it does not exist * Solve fiona.errors.DriverError: not recognized as a supported file format. * Remove rasterstats as a dependency for tests and docs * Codacy stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request improves the download of KNMI-data. It adds the parameter
most_common_stationtonlmod.read.knmi.get_recharge. When True, only data from the station that is most common in the model area is downloaded. This pull request also removes the call to the hydropandas method locations.geo.get_nearest_point, which can be quite slow.