Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nlmod.layers.fill_top_and_bottom() #275

Closed
dbrakenhoff opened this issue Oct 20, 2023 · 1 comment
Closed

Improve nlmod.layers.fill_top_and_bottom() #275

dbrakenhoff opened this issue Oct 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dbrakenhoff
Copy link
Collaborator

This method name is a bit vague considering the change from a 3D to 2D top is also performed.

Maybe we can call this to_modflow_tops_and_bottoms() which calls 2 functions, the first being fillnan_top_and_bottom() and the second make_top_2d()? Names need some work, because unstructured top is 1D...

And additionally, from Onno:

The code to fill nan values in the top and bottom can be optimized using the xarray bfill or ffill methods.
@dbrakenhoff dbrakenhoff added the enhancement New feature or request label Nov 2, 2023
@rubencalje
Copy link
Collaborator

Needs top be fixed together with issue #270

rubencalje added a commit that referenced this issue Nov 14, 2023
@rubencalje
Simplify fill_top_and_bottom
7858195 
See comment from Onno in issue #275
@rubencalje rubencalje mentioned this issue Nov 16, 2023
Merged
rubencalje added a commit that referenced this issue Nov 21, 2023
@rubencalje
Multiple improvements (#289)
23d9926 
* Multiple improvements

Update modpath executable
Add nlmod.plot.geotop_lithok_on_map()
Add "concentration" to perioddata in nlmod.gwf.buy()
Add optional "layer" argument to extrapolate_ds, so you can use method for geotop-data with layer="z" as well

* Simplify fill_top_and_bottom

See comment from Onno in issue #275

* Remove the layer dimension in top returned from get_regis

* Also remove the layer dimension in top returned from get_geotop

* Fix codacy issues

* Make sure add_geotop_to_regis_layers works without a layer dimension in top of regis and geotop

And fix codacy issue

* Make sure insert_layer works without a layer dimension in ds

And fix some tests
Fix extrapolate_ds for 2d-data-arrays

* Fix some geotop-errors

* Change mapserver layer for level areas of Wetterkip Fryslan

* Change extent of test, as Wetterskip Frysland does not return any geometries anymore

Change to HHNK

* Update url for level areas of noorderzijlvest

And improve test

* Process comments from @dbrakenhoff and other fixes

fix split_layer_ds and combine_layer_ds, and add tests
small fixes to notebooks

* Process more comments and improve tests

* Revert change which causes failed tests everywhere

* Add tests from plot.flopy, gwt and hfb

* Update 11_grid_rotation.ipynb

* Make a copy of the dataset in most methods in nlmod.layers

* Add docstrings and minor change in `set_model_top`

* Process comments from @dbrakenhoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbrakenhoff @rubencalje