Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

def _set_angrot_attributes(extent, xorigin, yorigin, angrot, attrs): #111

Closed
bdestombe opened this issue Oct 28, 2022 · 2 comments
Closed

def _set_angrot_attributes(extent, xorigin, yorigin, angrot, attrs): #111

bdestombe opened this issue Oct 28, 2022 · 2 comments
Assignees
@rubencalje
Labels
bug Something isn't working
Milestone
Release v0.4.0

Comments

@bdestombe
Copy link
Collaborator

def _set_angrot_attributes(extent, xorigin, yorigin, angrot, attrs): in resample.py requires extent to be a list and a tuple is not supported, as a tuple is immutable. modelgrid reutrns the extent as tuple.
@dbrakenhoff dbrakenhoff added the bug Something isn't working label Oct 28, 2022
@dbrakenhoff dbrakenhoff added this to the Release v0.4.0 milestone Oct 28, 2022
rubencalje added a commit that referenced this issue Nov 1, 2022
@rubencalje
fix issue #111 and codacy issue (gridtype not needed anymore in fill_…
0a91d44 
…top_bot_kh_kv_at_mask)
@rubencalje
Copy link
Collaborator

Issue is fixed by adding the line
extent = list(extent)

at the start of _set_angrot_attributes()

@rubencalje
Copy link
Collaborator

Fixed in PR #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubencalje rubencalje

Labels
bug Something isn't working
Projects
None yet
Milestone
Release v0.4.0
Development

No branches or pull requests
3 participants
@dbrakenhoff @bdestombe @rubencalje