solve minor bug and add test for most_common_station=True

gwmod · May 8, 2023 · c09949e · c09949e
1 parent 07aa8f3
commit c09949e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/nlmod/read/knmi.py b/nlmod/read/knmi.py
@@ -94,7 +94,7 @@ def get_recharge(ds, method="linear", most_common_station=False):
             # calculate recharge time series
             index = oc_knmi_prec.index[oc_knmi_prec.station == stn_rd][0]
             prec = oc_knmi_prec.loc[index, "obs"]["RD"].resample("D").nearest()
-            index = oc_knmi_evap.index[oc_knmi_evap.station == stn_rd][0]
+            index = oc_knmi_evap.index[oc_knmi_evap.station == stn_ev24][0]
             evap = oc_knmi_evap.loc[index, "obs"]["EV24"].resample("D").nearest()
             ts = (prec - evap).dropna()
             ts.name = f"{prec.name}-{evap.name}"

diff --git a/tests/test_005_external_data.py b/tests/test_005_external_data.py
@@ -11,6 +11,14 @@ def test_get_recharge():
     ds.update(nlmod.read.knmi.get_recharge(ds))
 
 
+def test_get_reacharge_most_common():
+    # model with sea
+    ds = test_001_model.get_ds_from_cache("basic_sea_model")
+
+    # add knmi recharge to the model dataset
+    ds.update(nlmod.read.knmi.get_recharge(ds, most_common_station=True))
+
+
 def test_get_recharge_steady_state():
     # model with sea
     ds = test_001_model.get_ds_from_cache("basic_sea_model")